Add missing signals to ChannelsAPI: player_joined, player_left, channel_ownership_transferred, channels_deleted.#72
Merged
tudddorrr merged 1 commit intoFeb 26, 2025
Conversation
tudddorrr
requested changes
Feb 25, 2025
Contributor
tudddorrr
left a comment
tudddorrr
left a comment
There was a problem hiding this comment.
really great stuff just one minor thing
| "v1.channels.player-left": | ||
| player_left.emit(TaloChannel.new(data.channel), TaloPlayerAlias.new(data.playerAlias)) | ||
| "v1.channels.ownership-transferred": | ||
| player_left.emit(TaloChannel.new(data.channel), TaloPlayerAlias.new(data.playerAlias)) |
Contributor
There was a problem hiding this comment.
this should be data.newOwner for the player alias
Contributor
Author
There was a problem hiding this comment.
Already fix now.
Daylily-Zeleen
force-pushed
the
add_missing_talo_signals-
branch
from
06d8151 to
33a1758
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A part of #70.