feat: add client-side validation to toast inputs#672
Merged
mikewheeleer merged 1 commit intoJul 25, 2026
Conversation
- Converted ToastDemo into a form with Title, Description, and Duration inputs - Added required and max-length constraints for toast attributes - Implemented accessible inline errors using FormField (aria-describedby) - Added dynamic client-side validation that blocks submission of invalid data - Wrote tests to cover all validation paths and edge cases
|
@AbuJulaybeeb Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
top work @AbuJulaybeeb — no notes. merging 🔥 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was done
ToastDemointo an interactive form with inputs for Title, Description, and Duration.FormFieldcomponent (aria-describedbyandrole="alert").toast-demo.test.tsxto guarantee robust validation coverage.Why it was done
Previously, the toast inputs accepted invalid values silently. By adding robust client-side validation and accessible inline errors, we prevent layout-breaking toast notifications and provide users with immediate, accessible feedback when they input invalid data, fulfilling the requirements for issue #654.
How it was verified
src/components/toast/__tests__/toast-demo.test.tsx.npm run lint,npm test, andnpm run buildwith full success and zero regressions.Closes #654