Skip to content

Disable room files in system tests#3149

Draft
samuelwei wants to merge 10 commits into
developfrom
disable-files-in-system-tests
Draft

Disable room files in system tests#3149
samuelwei wants to merge 10 commits into
developfrom
disable-files-in-system-tests

Conversation

@samuelwei

@samuelwei samuelwei commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Type

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Disable pre-uploaded slides in system tests

Other information

When the system tests are run in CI, the file download url point to http://localhost/.... -> BBB cannot download the test files

@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: dc8518d7-ae74-4142-b2b8-d4fa884ea918

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch disable-files-in-system-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented May 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.78%. Comparing base (fb65ca5) to head (fd843ad).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3149      +/-   ##
=============================================
- Coverage      96.80%   96.78%   -0.02%     
  Complexity      1944     1944              
=============================================
  Files            466      466              
  Lines          13291    13291              
  Branches        2190     2190              
=============================================
- Hits           12866    12864       -2     
- Misses           425      427       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cypress

cypress Bot commented May 21, 2026

Copy link
Copy Markdown

PILOS    Run #3093

Run Properties:  status check failed Failed #3093  •  git commit 2e80a54fcd: Disable room files in system tests
Project PILOS
Branch Review disable-files-in-system-tests
Run status status check failed Failed #3093
Run duration 03m 16s
Commit git commit 2e80a54fcd: Disable room files in system tests
Committer Samuel Weirich
View all properties for this run ↗︎

Test results
Tests that failed  Failures 3
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 12
View all changes introduced in this branch ↗︎

Tests for review

Failed  e2e/RoomsJoinWithLobby.cy.js • 3 failed tests • System tests

View Output

Test Artifacts
Room Join with lobby settings > Lobby disabled Test Replay Screenshots
Room Join with lobby settings > Lobby enabled Test Replay Screenshots
Room Join with lobby settings > Lobby enabled for guests only Test Replay Screenshots

@samuelwei samuelwei force-pushed the disable-files-in-system-tests branch 2 times, most recently from 5cd6f84 to 2159857 Compare May 21, 2026 10:15
@samuelwei samuelwei force-pushed the disable-files-in-system-tests branch from 9f94e97 to d75a9db Compare June 8, 2026 13:53
Comment thread .github/workflows/ci.yml Dismissed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants