Add SBML auto-export and fix silent HTTP errors#412
Merged
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://blue-flower-0c36fd81e-412.westus2.5.azurestaticapps.net |
There was a problem hiding this comment.
Pull request overview
This PR enhances SBOLCanvas’ embedded-mode integration by auto-exporting both SBOL and SBML to the parent iframe and by ensuring export-related HTTP failures are no longer silently ignored (and can be reported upstream).
Changes:
- Introduces a shared model-change Observable and adds an SBML auto-export postMessage pipeline alongside the existing SBOL pipeline (with separate debounces).
- Posts structured error messages to the parent window when SBOL/SBML export fails.
- Updates several
FilesServicemethods to propagate HTTP errors instead of swallowing them.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
SBOLCanvasFrontend/src/app/graph.service.ts |
Adds shared model-change stream and SBOL/SBML auto-export + error postMessage behavior when embedded. |
SBOLCanvasFrontend/src/app/files.service.ts |
Stops swallowing HTTP errors in multiple methods by forwarding errors through returned Observables. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://blue-flower-0c36fd81e-412.westus2.5.azurestaticapps.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SBOLCanvas only sent SBOL to the parent iframe. The parent also needs SBML for simulation, and HTTP errors in export calls were silently dropped.
postMessage(2000ms debounce, shares model-change Observable with SBOL)files.service.tsthat silently swallowed HTTP errors