Skip to content
This repository was archived by the owner on Jul 5, 2018. It is now read-only.

Added NSPredicate Playground#1

Open
dfreniche wants to merge 3 commits intoSwiftEducation:developfrom
dfreniche:devel/nspredicate
Open

Added NSPredicate Playground#1
dfreniche wants to merge 3 commits intoSwiftEducation:developfrom
dfreniche:devel/nspredicate

Conversation

@dfreniche
Copy link
Copy Markdown

@dfreniche dfreniche commented Jul 1, 2015

My first Playground.

It needs Xcode 7 Beta.
I'm not native English speaker, so maybe some typos / errors ahead

Thanks for any feedback

@ybakos
Copy link
Copy Markdown
Member

ybakos commented Jul 1, 2015

Thanks @dfreniche , I will take a look.

@ybakos
Copy link
Copy Markdown
Member

ybakos commented Jul 6, 2015

@dfreniche This is a really nice playground, but there are a handful of issues before I can merge this. See my inline comments. In general, there are two problems:

  1. Follow Swift best practices regarding properties (use let).
  2. Xcode 7 playgrounds are so unstable and quirky I am not sure if I can move any playgrounds forward yet or not.

dfreniche added 2 commits July 20, 2015 20:03
@dfreniche
Fixed some errors
ab1a770
@dfreniche
Removed all default useless values in classes' properties. Changed ev…
0f48f3e 
…ery non-mutating property into a let statement. Also, renamed some of these properties to be more consistent. Added a description method to all classes. Introduced better init to make code more compact.
@dfreniche
Copy link
Copy Markdown
Author

dfreniche commented Oct 23, 2015

@ybakos Hi, now looks like playgrounds are more stable. Tested OK with Xcode 7.1. What do you think?

@ybakos
Copy link
Copy Markdown
Member

ybakos commented Oct 23, 2015

@dfreniche Thanks, I'll take another look very soon.

ybakos pushed a commit that referenced this pull request Oct 29, 2015
NSPredicate playground.
be0f203 
Making significant content and code corrections.
Making formatting of markup consistent.
Changing authors and license information.
References #1.
@ybakos
Copy link
Copy Markdown
Member

ybakos commented Oct 29, 2015

@dfreniche Please take a look at the latest commit I made to your PR. Note the significant changes, the corrections, and new consistencies.
Most importantly, notice the change to the References playground - this needs to be Creative Commons, not MIT. If you are ok with what you see, then let me know, and I'll merge the playground in. Yay!

@dfreniche
Copy link
Copy Markdown
Author

dfreniche commented Feb 27, 2016

@ybakos Sorry, it took me forever to have the time / energy to look at that. Changing to a new job is hard.

I'm OK with that. Merge at your will ;-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dfreniche @ybakos