-
Notifications
You must be signed in to change notification settings - Fork 103
GET /payments/:id/webhooks has no pagination #124
Copy link
Copy link
Closed as not planned
Labels
GrantFox OSSIssue tracked in GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardIssue may be eligible for a GrantFox rewardOfficial Campaign | FWC26Campaign: Official Campaign | FWC26Campaign: Official Campaign | FWC26apiHTTP API surface and handlersHTTP API surface and handlersperformancePerformance / scalability concernPerformance / scalability concernwebhooksWebhook subsystemWebhook subsystem
Description
Activity
Metadata
Metadata
Assignees
Labels
GrantFox OSSIssue tracked in GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardIssue may be eligible for a GrantFox rewardOfficial Campaign | FWC26Campaign: Official Campaign | FWC26Campaign: Official Campaign | FWC26apiHTTP API surface and handlersHTTP API surface and handlersperformancePerformance / scalability concernPerformance / scalability concernwebhooksWebhook subsystemWebhook subsystem
Summary
The endpoint returns all deliveries for a payment in one response.
Location
src/api/payments.rs:350-378,src/db.rs:602-612IMPLEMENTATION_NOTES.mdlists pagination as future work.Details & impact
A payment with many retries/redeliveries returns an unbounded array, risking large responses and memory use.
Suggested fix
Add
limit/cursor pagination consistent with the payments list.Acceptance criteria