Fix 920 - #1027
Open
fahatadam wants to merge 2 commits into
Open
Conversation
|
@fahatadam is attempting to deploy a commit to the Ayomide Adeniran's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@fahatadam Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Title:
fix: type and test backend i18n middleware and localized error responses
Description:
What was done:
// @ts-nochecksuppressions frombackend/src/index.tsandbackend/src/routes/index.tsto un-suppress the i18n routing path and enforce type checking.backend/src/middleware/i18n.tsto robustly parsereq.headers['accept-language']arrays, explicitly enforcing safe type handling for the locale negotiation.LocalizedErrorclass inbackend/src/middleware/errorHandler.tsto create a strictly typed contract for translating backend errors.errorHandlerto interceptLocalizedErrorinstances, automatically fetching the localized message withreq.t(err.key), while safely falling back to a generic 500 error for standard native errors.i18n.test.ts) and global error handler fallback safety (errorHandler.test.ts).Why it was done:
To establish a typed and testable contract for locale selection and safe translated errors without suppressing type safety on the backend. This guarantees deterministic locale negotiation and prevents sensitive error information from leaking out during runtime exceptions.
How it was verified:
@ts-nocheckdirectives.Closes #920