🚨 [CRITICAL] v1 Deploy Route Uses Simulated Deployment Instead of Real Soroban CLI - #1017
Open
Martins-594 wants to merge 1 commit into
Open
Conversation
The /api/v1/deploy route was using a simulated deployment (Math.random, setTimeout) instead of actually invoking the Soroban CLI. This commit replaces the simulated deploy with a real deployService that calls 'soroban contract deploy' via child_process. - Create deployService.ts with proper Soroban CLI integration - Create deploy.routes.ts with POST /deploy endpoint - Register deploy route in routes/index.ts - Remove reliance on simulated Math.random/setTimeout patterns Closes StellarDevHub#993
|
@Martins-594 is attempting to deploy a commit to the Ayomide Adeniran's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Martins-594 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
/api/v1/deployendpoint was using a simulated deployment that generated random contract IDs withMath.random()andsetTimeout()instead of actually invoking the Soroban CLI.Location
backend/src/routes/deploy.routes.ts(previously simulated deploy)Issue
Despite the README claiming contracts are deployed to the Stellar Testnet, the route never actually executed
soroban contract deploy. The realdeployContract()function now exists inbackend/src/services/deployService.tsand is properly called by the deploy route.Impact
The previous simulated deploy returned fake contract IDs that could not be used for any real on-chain interaction. This made the deploy flow non-functional for production use.
Required Fix (implemented)
backend/src/services/deployService.tswithdeployContract()that invokes the Soroban CLI viachild_process.execFilebackend/src/routes/deploy.routes.tswithPOST /deploythat calls the real deploy servicebackend/src/routes/index.tsReference
Closes #993