fix: add env var validation warnings and centralized config defaults - #1014
Open
praise-idise wants to merge 1 commit into
Open
fix: add env var validation warnings and centralized config defaults#1014praise-idise wants to merge 1 commit into
praise-idise wants to merge 1 commit into
Conversation
Signed-off-by: --global <idisepraise@gmail.com>
|
@praise-idise is attempting to deploy a commit to the Ayomide Adeniran's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@praise-idise Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1001
Summary
The backend server silently defaulted critical environment variables
to localhost/testnet values without any warning. This adds clear
warning logs, SSL tracking, and replaces scattered inline fallbacks
with the centralized
getEnvVar()utility.Problem
REDIS_URL→redis://localhost:6379without warningNODE_ENV→developmentwithout warningSOROBAN_RPC_URL→ testnet without warningSTELLAR_NETWORK→ testnet without warningSSL_KEY_PATH/SSL_CERT_PATH→ not trackedprocess.env.X || 'fallback'What Changed
src/utils/checkEnv.tssrc/utils/redis.tssrc/config/redis.config.tstests/checkEnv.test.tsStartup Output Example