High] inconsistent soroban sdk - #1011
Open
gloskull wants to merge 2 commits into
Open
Conversation
…-contracts chore: standardize Soroban SDK version to 26.1.0 across contracts and playground
|
@gloskull is attempting to deploy a commit to the Ayomide Adeniran's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@gloskull Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
Hello, done with this project. Please if you have anymore projects of this sort, do assign more to me... PR will be submitted in under 10hours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
soroban-sdkversions across contract crates and the browser playground which can cause compile/runtime incompatibilities and contributor confusion.Description
Cargo.tomlfiles (workspace and individual crates) to usesoroban-sdk = "26.1.0"and updated dev-dependencies tosoroban-sdk = { version = "26.1.0", features = ["testutils"] }where present.DEFAULT_CARGO_TOMLinfrontend/src/app/playground/page.tsx) to usesoroban-sdk = "26.1.0"so browser-generated manifests match the repository standard.backend/src/services/dependency-update.service.tsto listsoroban-sdk/soroban-auth26.1.0and adjusted release notes to reference Protocol 26.README.mdand updated unit/test fixtures and assertions (backend and frontend) to expect26.1.0, including a resilient test assertion for the UI confirmation text inDependencyUpdatePanel.Testing
soroban-sdkversions via repository search (usedrgto confirm no20.x,21.xor22.xoccurrences remained) which succeeded.pnpm test -- dependency-update.service.test.tsand they passed.pnpm exec vitest run src/components/playground/__tests__/DependencyUpdatePanel.test.tsx src/hooks/__tests__/useDependencyUpdates.test.tsand they passed after updating fixtures and assertions.cargo check --workspaceandprisma generatecould not be completed in this environment due to network restrictions (crates.io / Prisma engine downloads returned HTTP 403), so Rust/Cargo verification and generation of Prisma client artifacts were blocked and could not be exercised here.Closes #997