Feature/xlm protocol - #791
Open
williamsokperez-arch wants to merge 3 commits into
Open
Conversation
…reserve Implement fast-path optimization for RecipientBalancePreCheck to skip detailed balance validation when account holds above minimum reserve plus a configurable threshold (default 10 XLM). This eliminates unnecessary Horizon round trips for the common case where accounts have well-funded balances. - Add skipThresholdXlm constructor option with default of 10 XLM - Log fast-path bypass at debug level for observability - Results from fast-path and full check are identical from caller perspective - Add comprehensive tests for default threshold, custom threshold, and boundaries Fixes Stellar-split#758 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
…itcher Prevent tx_bad_auth errors by ensuring in-flight operations complete before switching the active Stellar network endpoint. Pending transactions signed for one network could otherwise be submitted to a different one. - Add switchNetwork() method that awaits flushPending() before endpoint switch - Implement configurable flushTimeoutMs (default 5000) with graceful degradation - Emit warning if flush times out; remaining operations are cancelled - Network switch proceeds after flush or timeout - Maintain backward compatibility with deprecated switchTo() method - flushPending injected as dependency for testability Fixes Stellar-split#757 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Prevent silent network mismatch errors by validating custom passphrases against a definitive list of known Stellar networks. Reject typos of mainnet/testnet passphrases that would otherwise connect to unintended networks. - Export KNOWN_NETWORK_PASSPHRASES map with Stellar mainnet, testnet, futurenet - Add validatePassphrase() method for offline passphrase validation - Update validate() to check configured passphrase against known networks - Support allowUnknown option to permit custom passphrases when needed - Return networkLabel in ValidationResult for known networks Fixes Stellar-split#756 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
@williamsokperez-arch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #755
closes #756
closes #757
closes #758