feat(memo): add buildPaymentMemo and parsePaymentMemo helpers (#610) - #786
Draft
s6pa1rta3n-lab wants to merge 1 commit into
Draft
feat(memo): add buildPaymentMemo and parsePaymentMemo helpers (#610)#786s6pa1rta3n-lab wants to merge 1 commit into
s6pa1rta3n-lab wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
src/memoBuilder.tsbuilds transaction memos but lacked a standardised helper for the specific memo format used on invoice payment transactions. This PR adds canonicalbuildPaymentMemoandparsePaymentMemohelpers and exports them fromsrc/index.ts.Acceptance Criteria Checklist
buildPaymentMemo(invoiceId: string, opts?: { tranche?: number }): stringexported fromsrc/memoBuilder.ts"split:{invoiceId}"base case;"split:{invoiceId}:t{tranche}"when tranche provided; truncated to 28 bytes (Stellar memo text limit) with no mid-character cut on UTF-8parsePaymentMemo(memo: string): { invoiceId: string; tranche?: number } | nullexported — returnsnullfor non-split memosparsePaymentMemo(buildPaymentMemo(id, opts))returns the original inputssrc/index.tsCloses #610
/claim #610
Payout Routing
0xF46C9F6d70C50BF81ef3588AB523a90a594a2F89GCL6OXAMLD75BMTINA6EMRUDWK5THQUSHMYNLSNBCJAPZJHNYJTUNIBC