feat(background) - Add .bg-loading class and delete skeleton component #2136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0aac1e0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👷 Deploy Preview for stacks-svelte processing.
|
…/StackExchange/Stacks into spark-118/add-pulse-atomic-class
CGuindon
requested changes
Jan 20, 2026
Collaborator
CGuindon
left a comment
CGuindon
left a comment
There was a problem hiding this comment.
- Can you add a description below the 'Loading' title in the docs:
"The Loading utility applies a shimmering gradient animation to a container's background. Use this class to create flexible 'skeleton' placeholders that mimic the shape and layout of content while it loads." - The speed of the animation seems quite fast compared to what I'm seeing in Figma, can we slow this down closer to what's here.
Contributor
|
NIT: font-size of the paragraph for confetti and for loading is different. We should probably stick to the |
CGuindon
reviewed
Jan 21, 2026
Collaborator
CGuindon
left a comment
CGuindon
left a comment
There was a problem hiding this comment.
Looks great but the text in the documentation description looks off smaller/different font? Compared to the rest. It should match the text style that's under Confetti
Collaborator
Author
giamir
reviewed
Jan 21, 2026
.changeset/ninety-dogs-pump.md
Outdated
| "@stackoverflow/stacks-svelte": minor | ||
| --- | ||
|
|
||
| Add .is-loading delete skeleton |
giamir
approved these changes
Jan 21, 2026
CGuindon
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPARK-118
Figma
This PR adds the .bg-loading atomic class and removes the skeleton component from Stacks classic and svelte