fix: Image popover steals cursor focus#148
Open
colombo15 wants to merge 3 commits intoStackExchange:mainfrom
Open
fix: Image popover steals cursor focus#148colombo15 wants to merge 3 commits intoStackExchange:mainfrom
colombo15 wants to merge 3 commits intoStackExchange:mainfrom
Conversation
…ew's selectNode()
✅ Deploy Preview for nifty-lalande-39c157 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…into image-popover-steals-cursor-focus-122
Contributor
|
Ah, somehow I lost track of this PR. Thank you for the submission! I'll review this as soon as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #122
Moved the code to show the image popover to an onclick event on the img.
Added e2e test.