Conversation
…1941) * Enable $select improvement with select path and nested query options 1. Add the test case to verify the same derived property name 2. Fix the $ref test cases 3. Fix the base address case sensitive problem in the build agent. 4. Fix some failing e2e test cases 5. Address the comments
…f zero or greater.
… batch operations, PR OData#2012
1) Fix batch dispose issue (error writing to a closed stream) 2) Fix async batch issues (synchronous write to an asynchronous reader error)
-Case-insensitive header comparison -Default to JSON Batch response if request is JSON -Make sure stream is released before reading next request within a batch -Added/fixed tests for standard and .net core
…hronous writing behavior to avoid possible (though unlikely) breaking change. Note that any types directly deriving from ODataBatchResponseItem would have to be recompiled due to changes in abstract base class (abstract method now takes a writeAsync parameter). Seems highly unlikely that other custom types are deriving directly from ODataBatchResponseItem. In .NET 5, we should clean up the overloads that write to the stream synchronously, and probably make most of this internal (no reason to make the WriteResponseAsync/WriteMessageAsync on ODataBatchResponseItem public).
Batch Fixes
Fix DollarId test parallel running
* Added support for functions and constants in aggregate expression * Tests for more cannonical functions * Time tests * Support for compute transformation in $apply * Support sorting for columns introduced in compute * Remove redundant code * Fix flakyness in AggregateNavigationPropertyWorks * Fix the ToInt16 overflow during build * Fix typos * Make _values field private * Explicit way to mutate element type and lambda param * Test to demonstrate that we could run compute on complex entity properties * Support for complex types * Simplify keepoing ElementType and LambdaParameter in sync Co-authored-by: Sam Xu <saxu@microsoft.com>
* Everything except properties. Fix tests Address PR comments Remove Inline change due to a bug * Address PR comments and take sam's input parity between actions and functions self review Update tests fix final set of issues * Address PR comments address pr comments update method
…erty (OData#2160) * Fix logic for patching entity with complex type dynamic property * Support patching of complex type dynamic property in a structured type plus tests * Use string.IsNullOrWhiteSpace Co-authored-by: John Gathogo <jogathog@microsoft.com>
…h PathBase setting
Add System.Diagnostics.EventLog into ASP.NET Core 3.x E2E test project
* Fix bug 2177 - encode DateTimeOffset value in generated skip token * Fix bug 2177 - encode all types of parameters in generated skiptoken
* Add null check to TruncatedCollection. * Add test. Co-authored-by: Brecht Debaere <Brecht.Debaere@spray.com>
…tion property along with new Items IList<ODataItemBase> in ODataResourceSetWrapper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One approach to discuss for having legacy Resources property on ResourceSetWrapper, alongside new Items property inherited from ResourceSetWrapperBase.