fix: a11y changes for pathfinding control contrast

[julian1j]

Current light-theme contrast does not meet WCAG AA 4.5:1 for the "X", "Add Destination", and drag and drop icons introduced by multi-destination pathfinding. This addresses that by swapping text-neutral to text-light / text-main.

Description

Small change from text-neutral to text-light / text-main on the previously mentioned elements to enhance contrast and meet WCAG AA requirements.

Motivation and Context

Resolves BED-9546

Why is this change required? What problem does it solve?

How Has This Been Tested?

Tested locally in CE

Screenshots (optional):

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• I have met the contributing prerequisites
  • Assigned myself to this PR
  • Added the appropriate labels
  • Associated an issue: Issues and Pull Requests README #672
  • Read the Contributing guide: https://github.com/SpecterOps/BloodHound/wiki/Contributing
• I have ensured that related documentation is up-to-date
  • Open API docs
  • Code comments (GoDocs / JSDocs)
• I have followed proper test practices
  • Added/updated tests to cover my changes
  • All new and existing tests passed

Summary by CodeRabbit

• Style
  • Updated destination search controls with improved text colors for better visual consistency.
  • Preserved dark-mode styling and existing control behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: f8ea235b-ddb9-4e67-841d-a8e1e3bca0eb

📥 Commits

Reviewing files that changed from the base of the PR and between 71dc842 and 0f9b1e5.

📒 Files selected for processing (1)

• packages/javascript/bh-shared-ui/src/views/Explore/ExploreSearch/PathfindingSearch.tsx

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

---

📝 Walkthrough

Walkthrough

The pathfinding search controls now use semantic text-light and text-main classes. Dark-mode styling and control behavior remain unchanged.

Changes

Pathfinding search controls

Layer / File(s)	Summary
Semantic control colors packages/javascript/bh-shared-ui/src/views/Explore/ExploreSearch/PathfindingSearch.tsx	The reorder, remove, and add-destination controls now use semantic light and main text color classes instead of neutral gray classes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 0f9b1

This small UI change improves light-theme contrast for pathfinding controls without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies an accessibility fix for pathfinding control contrast. It matches the primary change.
Description check	✅ Passed	The description covers the change, motivation, issue reference, testing, screenshot, change type, and checklist. The testing details are brief but sufficient for a mostly complete description.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}