-
Notifications
You must be signed in to change notification settings - Fork 0
Write Codex a skill, not a prompt it stopped reading #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -203,6 +203,8 @@ fn command_path(spec: &HarnessSpec, dir: &std::path::Path, name: &str) -> PathBu | |
| .join("skills") | ||
| .join(format!("engram-{name}")) | ||
| .join("SKILL.md"), | ||
| // A bare skills root: no plugin wrapper, no manifest. | ||
| CommandSurface::Skill { .. } => dir.join(format!("engram-{name}")).join("SKILL.md"), | ||
| // Unreachable: the caller returns early for a harness with no surface. | ||
| CommandSurface::None { .. } => dir.join(name), | ||
| } | ||
|
|
@@ -357,7 +359,7 @@ pub fn install( | |
| let stale = pinned_db(&path).filter(|old| *old != db); | ||
|
|
||
| let body = match spec.command_surface { | ||
| CommandSurface::Plugin { .. } => { | ||
| CommandSurface::Plugin { .. } | CommandSurface::Skill { .. } => { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When installing AGENTS.md reference: AGENTS.md:L274-L275 Useful? React with 👍 / 👎. |
||
| render_skill(command.name, command.body, spec, &db) | ||
| } | ||
| _ => render_command(command.body, spec, &db), | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This switch leaves
plugins/engram/README.mdlines 32–47 directing Codex users to~/.codex/prompts/and explicitly stating that engram never ships skills because skill directories are unwritable. Those instructions are now the opposite of the installer behavior and will mislead users following the source-tree installation and Nix guidance; update that guide alongside the path change.Useful? React with 👍 / 👎.