feat: Dynamic Shard Hash Ring Re-Balancing across Active Keeper Nodes - #977
Merged
Conversation
|
@OG-wura is attempting to deploy a commit to the Ayomide Adeniran's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@OG-wura Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
pr under review, i will get back to you if i find any wrong implementations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #907
Dynamic Shard Hash Ring Re-Balancing across Active Keeper Nodes
Summary
Replaces the static modulo-based task sharding fallback with a consistent hash ring that dynamically redistributes task ownership when keeper nodes join or leave the cluster. Integrates with the existing P2P network for automatic node discovery and ring updates.
Changes
keeper/src/sharding.jsConsistentHashRingclass:addNode(nodeId)/removeNode(nodeId)— dynamic membership with O(log N) binary search lookuprebuildFromNodeIds(nodeIds)— batch rebuild for P2P syncclear()— reset ring statefilterTasksByHashRing(taskIds, ring, selfNodeId)— partitions tasks intoowned/skippedusing the ring, matching the existing shard return contract (ownedTaskIds,skippedTaskIds,shardCount,shardLabel)keeper/index.jsfilterTasksForShardas the non-P2P fallback inselectTaskOwnership()keeper-shard-{i}node IDs from staticshardCountpeer:updated/peer:staleevents — nodes joining or leaving the P2P cluster immediately trigger rebalancingHASH_RING_VNODESenv var (default: 150)keeper/__tests__/sharding.test.js18 new test cases covering:
rebuildFromNodeIds, task partitioning, null/empty edge casesKey Properties