Correct variable name and remove unneeded#261
Open
kentarohorie wants to merge 2 commits intoSorcery:mainfrom
Open
Correct variable name and remove unneeded#261kentarohorie wants to merge 2 commits intoSorcery:mainfrom
kentarohorie wants to merge 2 commits intoSorcery:mainfrom
Conversation
kentarohorie
changed the title
joshbuker
approved these changes
Nov 29, 2020
Member
joshbuker
left a comment
joshbuker
left a comment
There was a problem hiding this comment.
Needs some housekeeping stuff, but the code change itself looks good.
joshbuker
requested changes
Nov 29, 2020
Comment on lines
+99
to
+103
| authentication = send(authentications).build(sorcery_config.provider_uid_attribute_name => uid, | ||
| sorcery_config.provider_attribute_name => provider) | ||
| user.sorcery_adapter.save(validate: false) | ||
| authentication.sorcery_adapter.save(validate: false) | ||
| else | ||
| user = false | ||
| false |
Member
There was a problem hiding this comment.
Actually, looking closer at this, I think this changes the return value when the authentication is present. Previously it would return authentication, but with this change it would instead return authentication.sorcery_adapter.save(validate: false) as that's the last value called in the method.
Can you revert the second part of this, and keep it to just renaming the variable to be more accurate?
joshbuker
added
the
to be implemented in v1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to add changing about two points. It's simple refectoring.