Fix urlExists to use HTTPS for HTTPS URLs and make feedsession.json o…#66
Fix urlExists to use HTTPS for HTTPS URLs and make feedsession.json o…#66gvensan wants to merge 3 commits into
Conversation
…ptional in feed download The urlExists function used http for all requests, causing URL validation to silently fail on HTTPS URLs (like GitHub raw content). The feed download also hard-exited when feedsession.json was missing, even though it's not present in all community feeds.
There was a problem hiding this comment.
Pull request overview
This PR fixes URL validation for HTTPS endpoints in urlExists() and adjusts feed archival/download logic to treat feedsession.json as optional so community feeds without it can still be exported.
Changes:
- Update
urlExists()to choosehttpsvshttptransport based on the URL protocol. - Update feed archive download flow to attempt loading
feedsession.jsonand skip it if missing (instead of hard-exiting).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/utils/config.ts |
Switch urlExists() to use https for https: URLs. |
src/lib/feed-archive.ts |
Make feedsession.json optional during feed export by wrapping load/write in try/catch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
loadLocalFeedSessionFile - is the right call. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Make sense. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
| writeJsonFile(`${zipPath}/${defaultFeedRulesFile}`, data); | ||
| data = gitFeed ? await loadGitFeedFile(feedName, defaultFeedSessionFile) : loadLocalFeedFile(feedName, defaultFeedSessionFile); | ||
| writeJsonFile(`${zipPath}/${defaultFeedSessionFile}`, data); | ||
| try { |
There was a problem hiding this comment.
@gvensan out of curiosity - why do we need this new try block? arent we already defining data before this? and whats the difference between loadGitFeedSessionFile and loadGitFeedFile(same for the local)? I thought this PR is deals with using HTTPS for the transport request when needed
Fix urlExists to use HTTPS for HTTPS URLs and make feedsession.json optional in feed download
The urlExists function used http for all requests, causing URL validation to silently fail on HTTPS URLs (like GitHub raw content). The feed download also hard-exited when feedsession.json was missing, even though it's not present in all community feeds.