fix(programs): clamp completed-session nextWeek to program max week#233
Open
evan188199-tech wants to merge 1 commit into
Open
Conversation
The session-complete wrap incremented nextWeek = currentWeek + 1 without checking that the next week exists, so completing the last session of the last week out of order (while earlier sessions were still incomplete) wrote a currentWeek past the program's end, stranding the user on an empty "ghost week". Clamp the increment to the program's last week. The same wrap logic was duplicated in complete-program-session.action.ts and the session-progress complete route; fixed in both. Fixes Snouzy#232
|
Someone is attempting to deploy a commit to the Workoutcool Team Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
此 PR 由 GLM-5.2 修复。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Completing a program session out of order could write a
currentWeekthat doesn't exist in the program, stranding the user on an empty "ghost week".Bug found while auditing the programs API — not covered by any existing issue/PR.
Reproduction
Program: 2 weeks (W1: 2 sessions, W2: 2 sessions). Complete W2/S2 while W2/S1 is still incomplete (out-of-order completion, which the app otherwise supports).
Both
complete-program-session.action.tsandapp/api/programs/session-progress/[progressId]/complete/route.tsshare this wrap (duplicated verbatim):For
currentWeek=2, currentSession=2, completed count1 < total 4→isCompleted=false:The enrollment is saved
currentWeek=3, and on the program pagesetSelectedWeek(progress.stats.currentWeek)selects week 3 — which has no sessions. The user is stuck on an empty week (resume pointer permanently wrong until enough sessions flipisCompleted).Fix
Clamp the week increment to the program's last week:
When the program is genuinely done,
isCompletedalready guards the write. Verified against the repro: out-of-order completion now lands onweek 2 / session 1(a real week) instead ofweek 3. Fixed in both copies.Fixes #232.