Open
Conversation
fix ms-* stream id
Collaborator
|
Do you have an example case where the original code fails? Or if this is porting from Redis the commit that changed it is sufficient. |
|
I guess it's this upstream commit: redis/redis@21aa1d4 |
|
I believe that upstream change is to make the XADD more robust when an explicit ID is supplied (I am using the auto-generated ID and have not encountered any issues in KeyDB). If you are going to pull those changes, then it is probably a good idea to pull all the other changes as well, not just that snippet. |
Collaborator
|
Yes it looks like we're missing the tests too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix ms-* stream id