Skip to content

Add RecordCountValidatingPostProcessor#482

Draft
kmontemayor2-sc wants to merge 7 commits intomainfrom
kmonte/add-rcv-post-processor
Draft

Add RecordCountValidatingPostProcessor#482
kmontemayor2-sc wants to merge 7 commits intomainfrom
kmonte/add-rcv-post-processor

Conversation

@kmontemayor2-sc
Copy link
Collaborator

@kmontemayor2-sc kmontemayor2-sc commented Feb 10, 2026

Scope of work done

Doing this to verify our e2e tests are successful :P May be useful in the future to make sure people are exporting the correct number of embeddings/etc.

  • Adds RecordCountValidatingPostProcessor, a new post-processor that validates output BQ table integrity after inference. For each node type, it checks that the unenumerated embeddings/predictions tables exist and have the same row count as the corresponding enumerated_node_ids_bq_table from preprocessing. All errors are collected and reported together before failing.
  • Refactors PostProcessor to use protected (_) methods instead of name-mangled (__) methods, enabling clean subclassing without changing the public API.
  • Wires the new validator into all 4 link prediction e2e test configs (cora, dblp, and their graph store variants), so our e2e pipelines now automatically catch row count mismatches or missing output tables that would previously go undetected.

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: NO

@kmontemayor2-sc
Copy link
Collaborator Author

/e2e_test

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

GiGL Automation

@ 21:02:31UTC : 🔄 E2E Test started.

@ 21:18:39UTC : ❌ Workflow failed.
Please check the logs for more details.

@kmontemayor2-sc
Copy link
Collaborator Author

/unit_test_py

@kmontemayor2-sc
Copy link
Collaborator Author

/integration_test

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

GiGL Automation

@ 21:06:23UTC : 🔄 Python Unit Test started.

@ 22:22:48UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

GiGL Automation

@ 21:06:35UTC : 🔄 Integration Test started.

@ 22:40:24UTC : ✅ Workflow completed successfully.

@kmontemayor2-sc
Copy link
Collaborator Author

/unit_test_py

@kmontemayor2-sc
Copy link
Collaborator Author

/integration_test

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

GiGL Automation

@ 22:01:26UTC : 🔄 Integration Test started.

@ 23:07:17UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

GiGL Automation

@ 22:01:39UTC : 🔄 Python Unit Test started.

@ 22:09:12UTC : ❌ Workflow failed.
Please check the logs for more details.

@kmontemayor2-sc
Copy link
Collaborator Author

/unit_test_py

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

GiGL Automation

@ 22:56:32UTC : 🔄 Python Unit Test started.

@ 24:17:31UTC : ✅ Workflow completed successfully.

@kmontemayor2-sc
Copy link
Collaborator Author

/e2e_test

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

GiGL Automation

@ 23:34:53UTC : 🔄 E2E Test started.

@ 01:13:45UTC : ❌ Workflow failed.
Please check the logs for more details.

@kmontemayor2-sc
Copy link
Collaborator Author

/e2e_test

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

GiGL Automation

@ 17:59:55UTC : 🔄 E2E Test started.

@ 19:23:11UTC : ❌ Workflow failed.
Please check the logs for more details.

@kmontemayor2-sc
Copy link
Collaborator Author

/unit_test_py

@kmontemayor2-sc
Copy link
Collaborator Author

/integration_test

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

GiGL Automation

@ 18:01:50UTC : 🔄 Python Unit Test started.

@ 19:21:05UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

GiGL Automation

@ 18:01:56UTC : 🔄 Integration Test started.

@ 19:23:42UTC : ❌ Workflow failed.
Please check the logs for more details.

@kmontemayor2-sc
Copy link
Collaborator Author

/integration_test

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

GiGL Automation

@ 20:00:56UTC : 🔄 Integration Test started.

@ 21:15:42UTC : ✅ Workflow completed successfully.

@kmontemayor2-sc
Copy link
Collaborator Author

/e2e_test

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

GiGL Automation

@ 21:07:32UTC : 🔄 E2E Test started.

@ 22:27:28UTC : ❌ Workflow failed.
Please check the logs for more details.

@kmontemayor2-sc
Copy link
Collaborator Author

/e2e_test

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

GiGL Automation

@ 23:13:21UTC : 🔄 E2E Test started.

@ 24:18:16UTC : ❌ Workflow failed.
Please check the logs for more details.

@kmontemayor2-sc
Copy link
Collaborator Author

/e2e_test

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

GiGL Automation

@ 23:24:51UTC : 🔄 E2E Test started.

@ 24:57:14UTC : ❌ Workflow failed.
Please check the logs for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants