fix(unlock): use exact BigInt stroop conversion for asset unlocks (closes #76) - #328
Open
ghzhost wants to merge 1 commit into
Open
fix(unlock): use exact BigInt stroop conversion for asset unlocks (closes #76)#328ghzhost wants to merge 1 commit into
ghzhost wants to merge 1 commit into
Conversation
✅ Deploy Preview for spiffy-melomakarona-eb1e8a ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for smart-drop ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses and closes #76.
Problem
amountToStroops(supporting exact 7 decimal places and large values).unlockAssetswrapper andtoStroopsinsrc/types/farm.tsconverted display amounts viaMath.round(parseFloat(amount) * 10_000_000).toString().Number.MAX_SAFE_INTEGER / 1e7(e.g.900719925.4740993resulted in9007199254740992instead of9007199254740993).Changes
unlockAssets(src/lib/soroban.ts) withamountToStroops(amount).toString().toStroops(src/types/farm.ts) to useamountToStroops(displayAmount.toString()).toString().src/lib/soroban.partial-unlock.test.tsvalidating:Number.MAX_SAFE_INTEGERfloat precisionamountToStroopsbehaviorValidation
src/lib/soroban.partial-unlock.test.tspass cleanly (10/10 tests).soroban.test.ts,backend.retry.test.ts,validateEnv.test.ts,soroban.contractErrors.test.ts,soroban.feebump.test.ts,soroban.auth.test.ts,soroban.userPosition.test.ts,farmStore.test.ts) pass cleanly (68/68 tests).