Skip to content

fix: validate lock positions, min lock period, and typed errors - #259

Merged
ritaifeoluwa merged 1 commit into
SmartDropLabs:mainfrom
umuewu:fix/smartdrop-security-and-whitelist-enhancements
Aug 28, 2026
Merged

fix: validate lock positions, min lock period, and typed errors#259
ritaifeoluwa merged 1 commit into
SmartDropLabs:mainfrom
umuewu:fix/smartdrop-security-and-whitelist-enhancements

Conversation

@umuewu

@umuewu umuewu commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes position stake validation, minimum lock period validation, historical credit rate events, and typed errors for batch whitelist operations.

Closes #228
Closes #227
Closes #226
Closes #225

Changes proposed

What were you told to do?

Resolve assigned issues #228, #227, #226, #225.

What did I do?

Farming Pool & Factory Enhancements

  • Enforced total position stake check against minimum stake in lock_assets
  • Added minimum lock period validation in factory create_pool
  • Updated batch whitelist operations to return typed error BatchTooLarge
  • Included ledger sequence in rate_set events

Check List

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.
  • I am making a pull request against the main branch (left side).
  • My commit messages styles matches our requested structure.
  • The implementation was reviewed and confirmed to work as intended.
  • I am only making changes to files I was requested to.

@drips-wave

drips-wave Bot commented Aug 28, 2026

Copy link
Copy Markdown

@umuewu Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@netlify

netlify Bot commented Aug 28, 2026

Copy link
Copy Markdown

Deploy Preview for sdcontracts ready!

Name Link
🔨 Latest commit 9025066
🔍 Latest deploy log https://app.netlify.com/projects/sdcontracts/deploys/6a91e95febd6570008f5fc20
😎 Deploy Preview https://deploy-preview-259--sdcontracts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ritaifeoluwa
ritaifeoluwa merged commit 3bd6c2a into SmartDropLabs:main Aug 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants