Fix/issues 217 218 219 220 - #238
Merged
ritaifeoluwa merged 4 commits intoAug 28, 2026
Merged
Conversation
…opLabs#217) Ensure stake follows checks-effects-interactions by keeping set_user_stake and add_total_staked before the external token transfer.
Validate that start_ledger is not before the current ledger during initialize so vesting cannot begin with already-elapsed schedule time.
…pLabs#219) Verify pool pause/unpause entry points emit the expected on-chain events for full and granular pause controls.
…bs#220) Document how get_pool and list_pools refresh pool-record TTLs and add a list_pools TTL regression test aligned with get_pool behavior.
|
@od-hunter Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
✅ Deploy Preview for sdcontracts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #217
Closes #218
Closes #219
Closes #220