Skip to content

Feat/multi 186 187 188 189 - #212

Merged
ritaifeoluwa merged 5 commits into
SmartDropLabs:mainfrom
adetomiwa21:feat/multi-186-187-188-189
Aug 28, 2026
Merged

Feat/multi 186 187 188 189#212
ritaifeoluwa merged 5 commits into
SmartDropLabs:mainfrom
adetomiwa21:feat/multi-186-187-188-189

Conversation

@adetomiwa21

Copy link
Copy Markdown
Contributor

Summary of Changes

This PR implements protocol fixes across the smartdrop-contracts repository:

  1. Vesting Wallet Event Emission (vesting transfer_admin does not emit event #189): Added event test coverage ensuring transfer_admin emits (symbol_short!("vest"), symbol_short!("adm_xfr")).
  2. FarmingPool Staked User Count (No staked user count getter in FarmingPool #188): Added staked_user_count getter and automatic tracking when users enter or completely exit positions/stakes across stake, unstake, lock_assets, unlock_assets, and emergency_withdraw.
  3. FarmingPool Lock Assets Extension (lock_assets does not extend unlock_ledger when adding to existing position #187): Enforced and tested unlock_ledger extension when adding stake to an existing locked position.
  4. Factory WASM Hash Validation (set_pool_wasm_hash does not validate the hash is valid WASM #186): Implemented non-zero WASM hash validation in set_pool_wasm_hash and initialize with FactoryError::InvalidWasmHash.

Closes #186
Closes #187
Closes #188
Closes #189

@drips-wave

drips-wave Bot commented Aug 28, 2026

Copy link
Copy Markdown

@adetomiwa21 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@netlify

netlify Bot commented Aug 28, 2026

Copy link
Copy Markdown

Deploy Preview for sdcontracts ready!

Name Link
🔨 Latest commit b52f28e
🔍 Latest deploy log https://app.netlify.com/projects/sdcontracts/deploys/6a919e790023ff0008275516
😎 Deploy Preview https://deploy-preview-212--sdcontracts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ritaifeoluwa
ritaifeoluwa merged commit c566c07 into SmartDropLabs:main Aug 28, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants