Confusing naming: calculate_credits vs get_credits for different staking systems

[ritaifeoluwa]

Description

The FarmingPool's calculate_credits and get_credits functions have overlapping functionality. calculate_credits is for Position-based staking, get_credits is for UserStake-based staking. The naming is confusing.

Current behavior

• calculate_credits(user): returns credits for Position
• get_credits(user): returns credits for UserStake

Expected behavior

Either:

• Rename to get_position_credits and get_stake_credits
• Or merge into a single function that handles both
• Or document the distinction clearly

Why this matters

Developers may call the wrong function and get unexpected results.

Labels

documentation, farming-pool, good first issue

[MoscowDev]

I'd be happy to take this issue on. I have experience building production-ready applications and collaborating effectively through GitHub workflows, including implementing features, resolving bugs, and submitting well-documented pull requests.

I'll carefully review the existing implementation, identify the root cause, and deliver a robust, maintainable solution that aligns with the project's architecture and coding standards. Before submitting my PR, I'll thoroughly test the changes to ensure reliability and avoid regressions.

My goal is to contribute high-quality, clean, and maintainable code while communicating clearly throughout the process and delivering a dependable solution in a timely manner.

[sweetsoul21]

@sweetsoul21 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

hello maintainer, please assign me

ℹ️ Repo Maintainers: To accept this application, review their application or assign @sweetsoul21 to this issue.

[drips-wave]

Congratulations, @sweetsoul21! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @sweetsoul21: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[grantfox-oss]

🎉 This issue has been marked as completed on GrantFox as part of the Third Campaign campaign!

@sweetsoul21's PR #211 was approved and merged by @ritaifeoluwa.

🏆 @sweetsoul21: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (201 total points). Track your full progress on GrantFox.

👏 Great work, @sweetsoul21! Keep contributing to SmartDropLabs.

[drips-wave]

This issue has been completed by @sweetsoul21 as part of the Stellar Wave Program's 8th Wave 🥳

😎 @sweetsoul21: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.