fix(worker): omit empty topology config - #262
Closed
crliu3227 wants to merge 1 commit into
Closed
Conversation
crliu3227
requested review from
SkylerMalinowski,
alanmutsch,
catblade,
vivian-hafener and
wickberg
as code owners
September 9, 2026 06:23
Contributor
|
Good morning @crliu3227, I am looking into this. I believe that the issue reported in SlinkyProject/containers#20 could be resolved more simply via a change to the slurmd-entrypoint file logic in the containers repo, instead of a change to operator. I am pursuing that option via an internal MR. Once I have confirmed that my resolution resolves your issue, I will close this MR. Best, |
Contributor
|
I have an internal MR to https://github.com/SlinkyProject/containers that resolves this. I will update SlinkyProject/containers#20 with the commit ID once that is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Worker registration failures when no Slurm topology is configured.
The operator previously emitted an empty
Topology=entry inslurmd --conf.When the container entrypoint appended
CoreSpecCountandMemSpecLimit, Slurmparsed
CoreSpecCountas the topology value and marked the node asINVALID_REG.Changes
Topology=unless topology is explicitly configured throughNodeSet.spec.extraConf.SLINKY_TOPOLOGYenvironment variable.Topology=<value>configuration throughextraConf.--confoutput.Result
Workers without topology now register with resource configuration similar to:
Fixes SlinkyProject/containers#20