Repository navigation
Summarize the catalog in the Raster Sampling table - #1129
Merged
Merged
Conversation
The table printed every field of a sampler row, including the whole catalog. With the 1.45 MB catalog from the #1118 live test the row was over 200,000 px tall, so the panel looked blank and the form below it was pushed out of view; loading such a request back into the Request view did the same. The catalog column now shows a summary: "N features, size" for a GeoJSON catalog, the size for other text, and nothing when there is no catalog. The other columns are unchanged. The file is also reformatted with Prettier, which it hadn't been. Closes #1126 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #1126: the Raster Sampling table (
SrRasterParamsDataTable.vue) rendered every field of a sampler row, including the whole catalog. With the 1.45 MB catalog from the #1118 live test, the row was 214,567 px tall, so the panel looked blank and Add New Raster Params was pushed about 215,000 px down. Loading such a request back into the Request view did the same.formatBytes.#bodyslot andcatalogSummary().Closes #1126
Test plan
make pre-commit-checkpassed on commit (incl. the 4 new tests inSrRasterParamsDataTable.spec.ts, which mount the real PrimeVue table; the 3 catalog tests fail against the old component)make runwith a Playwright script (not committed), uploading the 1.45 MB catalog through the button and adding a row: the catalog cell reads "2,995 features, 1.38 MB", the row is 79 px tall and Add New Raster Params is at y = 546 px. With the old component the cell held all 1,451,219 characters, the row was 214,567 px tall and the button was at y = 215,024 px.🤖 Generated with Claude Code