Skip to content

Summarize the catalog in the Raster Sampling table - #1129

Merged
cugarteblair merged 1 commit into
mainfrom
issue-1126-raster-table-catalog
Sep 28, 2026
Merged

cugarteblair merged 1 commit into
mainfrom
issue-1126-raster-table-catalog

Conversation

@cugarteblair

Copy link
Copy Markdown
Member

Summary

Issue #1126: the Raster Sampling table (SrRasterParamsDataTable.vue) rendered every field of a sampler row, including the whole catalog. With the 1.45 MB catalog from the #1118 live test, the row was 214,567 px tall, so the panel looked blank and Add New Raster Params was pushed about 215,000 px down. Loading such a request back into the Request view did the same.

  • The catalog column now shows a summary: "N features, size" for a GeoJSON catalog (e.g. "2,995 features, 1.38 MB"), just the size for other text, and nothing when there's no catalog. The size uses the app's formatBytes.
  • Summaries are computed once per change to the table's rows, so a large catalog isn't re-parsed on every render.
  • The other columns are unchanged, and the Catalog text box still holds the full text.
  • The file is reformatted with Prettier, which it hadn't been, so most of its diff is formatting. The change itself is the catalog column's #body slot and catalogSummary().

Closes #1126

Test plan

  • make pre-commit-check passed on commit (incl. the 4 new tests in SrRasterParamsDataTable.spec.ts, which mount the real PrimeVue table; the 3 catalog tests fail against the old component)
  • make run with a Playwright script (not committed), uploading the 1.45 MB catalog through the button and adding a row: the catalog cell reads "2,995 features, 1.38 MB", the row is 79 px tall and Add New Raster Params is at y = 546 px. With the old component the cell held all 1,451,219 characters, the row was 214,567 px tall and the button was at y = 215,024 px.

🤖 Generated with Claude Code

The table printed every field of a sampler row, including the whole
catalog. With the 1.45 MB catalog from the #1118 live test the row was
over 200,000 px tall, so the panel looked blank and the form below it
was pushed out of view; loading such a request back into the Request
view did the same.

The catalog column now shows a summary: "N features, size" for a
GeoJSON catalog, the size for other text, and nothing when there is no
catalog. The other columns are unchanged. The file is also reformatted
with Prettier, which it hadn't been.

Closes #1126

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cugarteblair
cugarteblair merged commit b8545b0 into main Sep 28, 2026
1 check passed
@cugarteblair
cugarteblair deleted the issue-1126-raster-table-catalog branch September 28, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Raster Sampling table shows the full catalog text

1 participant