Repository navigation
Send an uploaded raster catalog with the request - #1127
Merged
Merged
Conversation
"Upload a Catalog File" parsed the file and reported success, but stored it in catalogStore, which nothing read, so the catalog never reached the request. It now fills the Catalog box, the same as pasting, and "Add New Raster Params" copies it into the sampler row. catalogStore is removed. The file picker also only accepted .smp/.smpr files, left over from an early draft of the component, so a .geojson or .json catalog couldn't be chosen. It now accepts .geojson and .json, like the region upload. Closes #1124 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #1124: in Raster Sampling, Upload a Catalog File read and parsed the file and showed "Catalog file successfully loaded", but the catalog never reached the request.
SrCatalogFileUpload.vuestored it incatalogStore, which nothing read. The sampler row'scatalogcomes only from the Catalog box (rasterParamsStore.catalog). The upload now fills that box with the file's text, the same as pasting, and Add New Raster Params copies it into the row.catalogStore.tsis removed.accept=".smp,.smpr", left over from an early draft of the component, so.geojsonand.jsonfiles couldn't be chosen. It now accepts.geojson,.json, like the region upload.The upload still only checks that the file is valid JSON.
Closes #1124
Test plan
make pre-commit-checkpassed on commit (lockfiles, lint-staged, typecheck, unit tests incl. the 3 in the newSrCatalogFileUpload.spec.ts, two of which fail against the old component)make runwith a Playwright script (not committed): uploaded a real 4-tileusgs3dep-1meter-demcatalog through the button → success toast, the Catalog box holds the file text, and after adding a row thesamplesthe request would send carry the catalog (read from the store; nothing sent to a server)🤖 Generated with Claude Code