Repository navigation
Stop the tour and advice toasts from opening by themselves - #1122
Merged
Merged
Conversation
A managed browser that wipes site storage every few weeks made the client treat each update as a first visit: the Quick Tour started as a blocking overlay over the Run button, and "Helpful Advice" toasts (gated on having fewer than 2-4 stored records) stayed for 60 s over the request controls. Losing that storage is now harmless. Nothing advice-like opens on its own; the app-bar Tour button becomes a Help menu (Quick Tour, Long Tour, Show tips) that pulses until it is first opened. Tips are off by default and all go through requestsStore.showTip. Tips requested together (one view mounting) are combined into one toast, duplicates dropped, that stays up 4 s plus 0.5 s per word. The new helpStore replaces tourStore and migrates the old srTourSeen key so existing users don't see the pulse. The no-region error now carries its own advice instead of a second toast, and the obsolete "Threshold for Helpful Advice" setting is removed. The E2E fixture that clicked through the auto-started tour becomes appPage; help_menu.e2e.spec.ts covers the new first-visit behavior. Closes #1088 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #1088: on a managed browser that wipes site storage every few weeks, each update made the client act as if it were a first visit. The Quick Tour started as a blocking intro.js overlay (step 4 covers the Run button), and up to nine "Helpful Advice" toasts appeared top-left for 60 s. Those toasts were gated on having fewer than 2–4 stored records, not on a "seen" flag.
We can't make storage survive for anonymous users, so this makes losing it harmless:
App.vueno longer starts the Quick Tour on mount.SrAppBar.vue): Quick Tour, Long Tour (disabled off the map views) and a Show tips switch. The button shows on every route and pulses until first opened;prefers-reduced-motiongets a static glow.requestsStore.showTip()replacesdisplayHelpfulMapAdvice/displayHelpfulPlotAdvice/needAdviceandhelpfulReqAdviceCnt; all nine call sites use it.SrPlotConfiginstances).showTipnow collects tips for 300 ms, drops duplicates and shows one toast (utils/tipUtils.ts) that stays up 4 s + 0.5 s per word; hovering pauses it.helpStorereplacestourStore(persisted to localStorage:helpOpened,showTips). It migrates the legacysrTourSeenkey once, so existing users don't see the pulse.workerDomUtils.tsincludes its advice instead of adding a second toast.Closes #1088
Test plan
make pre-commit-checkpassed on commit (lockfiles, lint-staged, typecheck, unit tests incl. newhelpStore.spec.tsandtipUtils.spec.ts)make test-e2eon Chromium: newhelp_menu.e2e.spec.ts, plus the existing specs on the renamedappPagefixture🤖 Generated with Claude Code