Merged
Conversation
UnderscoreTud
requested review from
Burbulinis and
sovdeeth
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
sovdeeth
requested changes
Dec 26, 2025
src/main/java/org/skriptlang/skript/bukkit/misc/events/EvtPlayerPickItem.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/events/EvtPlayerPickItem.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/events/EvtPlayerPickItem.java
Outdated
Show resolved
Hide resolved
sovdeeth
approved these changes
Dec 29, 2025
src/main/java/org/skriptlang/skript/bukkit/misc/events/EvtPlayerPickItem.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/events/EvtPlayerPickItem.java
Outdated
Show resolved
Hide resolved
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
…eature/player-pick-item-event # Conflicts: # src/main/java/ch/njol/skript/Skript.java # src/main/java/org/skriptlang/skript/bukkit/misc/MiscModule.java # src/main/java/org/skriptlang/skript/bukkit/misc/elements/expressions/ExprPickedItem.java
APickledWalrus
approved these changes
Mar 27, 2026
Member
APickledWalrus
left a comment
APickledWalrus
left a comment
There was a problem hiding this comment.
Looks pretty good overall, nice work
src/main/java/org/skriptlang/skript/bukkit/misc/elements/expressions/ExprPickedItem.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/elements/expressions/ExprPickedItem.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/elements/expressions/ExprPickedItem.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/events/EvtPlayerPickItem.java
Outdated
Show resolved
Hide resolved
skriptlang-automation
bot
added
the
feature-ready
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.15 Releases
skriptlang-automation
bot
removed
the
needs reviews
skriptlang-automation
bot
added
the
completed
github-project-automation
bot
moved this from Awaiting Merge
to Done - Awaiting Release
in 2.15 Releases
skriptlang-automation
bot
removed
the
feature-ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Skript doesn't have support for the PlayerPickItemEvent, called when a player performs the pick block action (usually middle clicking a block or an entity)
Solution
Add support for the event alongside an expression to get the picked item, block or entity
Testing Completed
EvtPlayerPickItemTest.skand manual testingSupporting Information
N/A
Completes: none
Related: none
AI assistance: none