Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates several references and minor behaviors, including changes in test outputs, API calls, package versions, and CI workflow improvements.

  • Updated expected newline count in a text rendering test
  • Changed API call syntax for image bounds in FillProcessor and FillPathProcessor
  • Upgraded package reference versions and improved the Ubuntu CI workflow step

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/ImageSharp.Drawing.Tests/Drawing/Text/DrawTextOnImageTests.cs Updated the expected newline repetition count in the text rendering test.
src/ImageSharp.Drawing/Processing/Processors/Drawing/FillProcessor{TPixel}.cs Modified API call syntax from a method call to a property for retrieving image bounds.
src/ImageSharp.Drawing/Processing/Processors/Drawing/FillPathProcessor{TPixel}.cs Modified API call syntax from a method call to a property for retrieving image bounds.
src/ImageSharp.Drawing/ImageSharp.Drawing.csproj Updated package versions for SixLabors.Fonts and SixLabors.ImageSharp.
.github/workflows/build-and-test.yml Updated Ubuntu package installation step via improved condition and added apt-get update.
Comments suppressed due to low confidence (1)

tests/ImageSharp.Drawing.Tests/Drawing/Text/DrawTextOnImageTests.cs:272

  • The increase in newline repetitions from 31 to 61 should be confirmed against the intended text output. Ensure that all related test expectations and baselines are updated to reflect this change.
string newLines = Repeat("\r\n", 61);

@JimBobSquarePants JimBobSquarePants merged commit ed1b3ee into main May 30, 2025
15 checks passed
@JimBobSquarePants JimBobSquarePants deleted the js/v4-refs-update branch July 11, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants