Add building and container recipes#23
Closed
silasmue wants to merge 3 commits intoSimulation-Software-Engineering:mainfrom
Closed
Add building and container recipes#23silasmue wants to merge 3 commits intoSimulation-Software-Engineering:mainfrom
silasmue wants to merge 3 commits intoSimulation-Software-Engineering:mainfrom
Conversation
MakisH
reviewed
Apr 11, 2026
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
Everything looks good here and works, thanks!
There was a problem hiding this comment.
I would not add generated binaries to a git repository. In the same way you have build/ in the .gitignore, you could also add this.
| && cd /tmp \ | ||
| && rm -rf yaml-cpp-0.6.3.zip yaml-cpp-yaml-cpp-0.6.3 | ||
|
|
||
| ENV LD_LIBRARY_PATH="/usr/local/lib:${LD_LIBRARY_PATH}" |
There was a problem hiding this comment.
FYI, LD_LIBRARY_PATH at the right-hand side is not defined at this point.
| ENV LD_LIBRARY_PATH="/usr/local/lib:${LD_LIBRARY_PATH}" | ||
|
|
||
| # Setup workdir to mount, to mount files | ||
| WORKDIR /opt/cmake-exercise |
There was a problem hiding this comment.
I would expect this WORKDIR to always exist and have files. It currently depends on the user-defined mount.
| ) | ||
|
|
||
| # Setup Deal.II | ||
| DEAL_II_SETUP_TARGET(main) |
There was a problem hiding this comment.
FYI, in CMake, uppercase and lowercase are equivalent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My GitLab name is muelless. For instructions please follow the provided README.md.