Skip to content

fix(tauri): remove macOS specific titlebar config from base tauri.con… - #111

Open
Ronak-webdev wants to merge 2 commits into
Sidenai:mainfrom
Ronak-webdev:fix-double-title-bar
Open

fix(tauri): remove macOS specific titlebar config from base tauri.con…#111
Ronak-webdev wants to merge 2 commits into
Sidenai:mainfrom
Ronak-webdev:fix-double-title-bar

Conversation

@Ronak-webdev

Copy link
Copy Markdown

Description

This PR fixes the double title bar issue experienced on Windows.

The base tauri.conf.json contained macOS-specific configurations (titleBarStyle: Overlay and hiddenTitle: true). These were causing Tauri to render a second native title bar alongside the custom frontend title bar on Windows 11.

I have removed these properties from the base tauri.conf.json. Since they are already properly defined in tauri.macos.conf.json, the macOS build remains unaffected, and the issue is resolved on Windows.

Fixes #93

Copilot AI review requested due to automatic review settings July 31, 2026 18:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes macOS-specific window titlebar settings from the shared Tauri configuration to prevent Windows from rendering a second native title bar alongside the app’s custom frontend title bar (Fixes #93).

Changes:

  • Removed titleBarStyle: "Overlay" and hiddenTitle: true from the base src-tauri/tauri.conf.json.
  • Kept macOS behavior intact by relying on src-tauri/tauri.macos.conf.json, which still defines these macOS-only properties.

Copilot AI review requested due to automatic review settings August 1, 2026 18:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (2)

src/main.ts:145

  • The non-reuse path assumes a Tauri runtime and does a dynamic import of @tauri-apps/api/core outside of any try/catch. In a non-Tauri/browser context (this file already supports non-Tauri execution via try/catch around other Tauri imports), this can reject the workspaceProvider.open promise and break opening workspaces in a new window. Guard on __SIDEX_TAURI__ (or catch the import) and fall back to window.open when not running in Tauri.
					// Open in a new Tauri window
					const { invoke } = await import('@tauri-apps/api/core');
					const url = new URL(window.location.href);
					if (folderUriStr) {
						url.searchParams.set('folder', folderUriStr);

src/main.ts:135

  • PR description focuses on removing macOS-only titleBarStyle/hiddenTitle from tauri.conf.json to fix the double title bar issue, but this PR also changes workspace opening behavior by introducing a new-window flow via invoke('create_window', ...). Please update the PR description (or split the change) so reviewers understand why this behavior change is included with the title bar fix.
					// Open in a new Tauri window
					const { invoke } = await import('@tauri-apps/api/core');
					const url = new URL(window.location.href);
					if (folderUriStr) {
						url.searchParams.set('folder', folderUriStr);
					} else {
						url.searchParams.delete('folder');
					}
					const label = 'window-' + Date.now();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double title bar

2 participants