Repository navigation
Add per-instance Net::HTTP Semian policy - #1052
Draft
serioushaircut wants to merge 1 commit into
Draft
serioushaircut wants to merge 1 commit into
serioushaircut wants to merge 1 commit into
Conversation
Allow callers and HTTP client frameworks to opt out of the process-wide policy or replace it before the first Semian lookup. Co-authored-by: GPT-5.6-sol <noreply@openai.com> Orchestrated-by: ae <noreply@shopify.com> Assisted-By: devx/3865f48a-5615-4606-8a95-0f0ef753aa15
serioushaircut
force-pushed
the
ae-task-1128-add-explicit-per-instance-net-http-semia
branch
from
September 21, 2026 13:45
7a0c0a1 to
6608ae5
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an explicit per-instance policy to the Net::HTTP adapter so callers can inherit the process-wide configuration, disable Semian, or replace the whole resource with caller-owned options. This lets HTTP client frameworks configure an already-created
Net::HTTPobject before its first Semian lookup.Approach
semian:andsemian: trueas inheritance fromSemian::NetHTTP.semian_configurationsemian: falseas a complete opt-out and a hash as a complete replacement, without merging platform circuit-breaker or bulkhead settingssemian_policy=for pre-use framework integration, defensively copy and freeze caller options, allow idempotent repeats, and reject policy changes after assignment or usedynamic: truefor immutable instance policiesValidation
bundle exec rubocop(134 files, no offenses)Co-authored-by: GPT-5.6-sol noreply@openai.com
Orchestrated-by: ae noreply@shopify.com