Throw specific error types when calling functions that are relesed or…#616
Draft
andrewmcgov wants to merge 1 commit into
Draft
Throw specific error types when calling functions that are relesed or…#616andrewmcgov wants to merge 1 commit into
andrewmcgov wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
@remote-ui/rpcserializes functions as revocable RPC proxies. Calling a proxy after its target was released, or after the endpoint was terminated, previously threw a genericErrorwhose only signal was a message string.This PR introduces two exported
Errorsubclasses thrown fromcreateBasicEncoder(packages/rpc/src/encoding/basic.ts):RemoteFunctionReleasedError— use-after-free: thecall()site when the target function is gone, and the proxy when it's already been released.RemoteFunctionRevokedError— the proxy was revoked because the endpoint was terminated.Both follow the existing
MissingResolverErrorpattern (extendsError, setsthis.name) and are re-exported from the package root.Why
Consumers currently string-match
message.includes('already released' | 'already revoked')to triage these in error reporting. With named types, consumers can useinstanceof(or the stableerror.name) and tell the two cases apart.