Add Payment model with Decimal amounts and PaymentStatus. - #44
Open
sainath5001 wants to merge 1 commit into
Open
Add Payment model with Decimal amounts and PaymentStatus.#44sainath5001 wants to merge 1 commit into
sainath5001 wants to merge 1 commit into
Conversation
Introduce ShadeObject base for from_dict/to_dict, add Payment and PaymentStatus (str, Enum for Python 3.10), validate amount > 0, declare pydantic in pyproject.toml, and cover the model with unit tests.
Contributor
📝 WalkthroughWalkthroughAdds Pydantic-based Shade models with shared serialization helpers, a typed ChangesPayment models
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
14 tasks
Contributor
|
GM @sainath5001 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce
ShadeObjectbase forfrom_dict/to_dict, addPaymentandPaymentStatus(str, Enumfor Python 3.10), validateamount > 0, declarepydanticinpyproject.toml, and cover the model with unit tests.This adds the typed Payment API response model so monetary amounts use
Decimal(not float) and status values are validated via enum.Dependency:
pydantic >= 2.0(added topyproject.toml;poetry.lockcontent-hash updated).Fixes #37
Type of change
How Has This Been Tested?
pytest— full suite (146 passed)tests/models/test_payment.py—from_dict, Decimal amount, PaymentStatus enum, invalid status errors, amount > 0Checklist:
Summary by CodeRabbit