Correctif des lettres qui n'étaient pas récupérable à certains moments#1218
Open
gtolontop wants to merge 2 commits intoServerOpenMC:masterfrom
Open
Correctif des lettres qui n'étaient pas récupérable à certains moments#1218gtolontop wants to merge 2 commits intoServerOpenMC:masterfrom
gtolontop wants to merge 2 commits intoServerOpenMC:masterfrom
Conversation
2916e5e to
c741b88
Compare
Member
|
Pourquoi tu modifie la class |
Contributor
Author
|
Il manque des accolade c'est écrit :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrige le bug où les items de la mailbox disparaissaient lors de l'acceptation d'une lettre.
Problème
Dans
LetterMenu.accept(), les items étaient récupérés aprèsdeleteLetter(), qui supprime la lettre du cache en mémoire.MailboxManager.getById()retournait alorsnulldans leClaimLetterEvent, etletter.getCachedItems()pouvait échouer silencieusement — les items étaient perdus sans message d'erreur.Le problème se manifestait principalement quand l'expéditeur était déconnecté et que la lettre avait été envoyée avant un redémarrage serveur.
Correction
resolveItems()qui cache les items désérialisés dans un champresolvedItems, évitant la double désérialisation entregetContent()etaccept()resolveItems()avantdeleteLetter()pour garantir que les items sont disponiblesClaimLetterEventClaimLetterEventreçoit directement l'objetletterau lieu degetById()post-suppressionFixes #1167, fixes #1084