Correction de la profondeur du Hammer (3x3x3 → 3x3x2)#1217
Open
gtolontop wants to merge 1 commit intoServerOpenMC:masterfrom
Open
Correction de la profondeur du Hammer (3x3x3 → 3x3x2)#1217gtolontop wants to merge 1 commit intoServerOpenMC:masterfrom
gtolontop wants to merge 1 commit intoServerOpenMC:masterfrom
Conversation
Member
|
On peut avoir des screens? |
iambibi
reviewed
Mar 22, 2026
Member
iambibi
left a comment
iambibi
left a comment
There was a problem hiding this comment.
je peux pas réelement review cela, axeno connait son code est pourra mieux dire si ça passe (apres un screen d'exemple de cassage de bloc est nécessaire pls)
Contributor
Author
|
Cest juste qu'on change la profondeur de 1 ça peux pas vrm faire grand chose d'autre que de le passer en 2 au lieu de 3 |
Member
|
Je laisse axeno et d'autres mainteneur review |
Member
|
Effectivement, c'etait volontaire sans l'etre |
AxenoDev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrige le bug où le Hammer en diamant minait en 3×3×3 au lieu de 3×3×2.
Problème
Dans
Hammer.breakArea(), la boucle de profondeur (dz) allait de-depthà+depth, minant des blocs dans les deux directions par rapport à la face frappée. De plus,rotateOffset()ne différenciait pas les directions opposées (NORTH/SOUTH partageaient le même vecteur), ce qui rendait impossible la correction via la boucle seule.Correction
dzchangée de-depth..depth→0..depthpour ne miner que dans une seule directionrotateOffset()gère maintenant chaque face individuellement avec le bon signe, garantissant que la profondeur va toujours dans la direction correcte (vers l'intérieur du bloc miné)Fixes #1151