fix(dataset): make mmap conversation reads concurrency-safe - #37
Merged
Conversation
Signed-off-by: Cam Quilici <cjquilici@gmail.com>
Try out this PRQuick install: pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@67a42758b366589951cdecc06087e0a6cf88603dRecommended with virtual environment (using uv): uv venv --python 3.12 && source .venv/bin/activate
uv pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@67a42758b366589951cdecc06087e0a6cf88603dLast updated for commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
MemoryMapDatasetClient.get_conversation()usedseek()followed byread()on one mmap object shared by executor threads. Parallel AgentX warmup reads could move the shared cursor between those calls, returning the wrong or truncated JSON record.Validation
uv run pytest tests/unit/dataset/test_payload_mmap.py tests/unit/dataset/test_memory_map_compress.py tests/unit/dataset/test_mmap_cache.py -q(94 passed)pre-commit run --files src/aiperf/dataset/memory_map_utils.py tests/unit/dataset/test_payload_mmap.py