chore(agentx): bump AIPerf to agentx-v1.0.4 [no breaking changes, no perf effect] - #2548
Conversation
Signed-off-by: Cam Quilici <cjquilici@gmail.com>
|
Claude finished @cquil11's task in 1m 13s —— View job Review of PR #2548
LGTM - no blocking issues found. The diff is exactly one gitlink change in Note: I could not independently re-resolve the upstream tag to its commit SHA from this environment (network |
There was a problem hiding this comment.
LGTM — straightforward submodule pointer bump for utils/aiperf (agentx-v1.0.3 → agentx-v1.0.4).
Extended reasoning...
Overview
The PR changes a single line: the gitlink for the utils/aiperf submodule, advancing it from commit bcfc235c5 to 49634d1c6 (tag agentx-v1.0.4). No other files in InferenceX are touched. The upstream change (per the linked release/PR) adjusts AgentX's profiling-coverage validation to accept either late TTFT or late ITL as proof of server activity near the profile boundary, fixing false-positive run invalidations observed in two linked CI runs.
Security risks
None. This is a pointer bump to a vetted internal submodule (SemiAnalysisAI/aiperf) with a tagged, non-draft, non-prerelease release. No new code is introduced into this repo, no changes to request payloads, auth, or execution paths within InferenceX itself.
Level of scrutiny
Low. Submodule bumps of this kind are mechanical — the actual logic change lives and was tested upstream (103 unit tests, pre-commit hooks per the description), and the InferenceX-side diff is a single gitlink line. The PR description explicitly confirms no breaking changes, no perf impact, and no changes to workload pacing/concurrency/routing.
Other factors
No bugs were found by the bug hunting system, and the diff is minimal and self-contained enough that a human reviewer would add little beyond confirming the commit hash resolves correctly, which the author already verified.
Summary
utils/aiperffromagentx-v1.0.3(bcfc235c552a17de6d1a7a5d2345cf012401588d) toagentx-v1.0.4(49634d1c6c2e6dcc18979d704a65e7c7064efc49)Behavior
AgentX keeps the 98% profiling-coverage threshold but now accepts either late TTFT or late ITL as proof of global server activity. This prevents healthy long-running streams from failing solely because no new request starts near the profile boundary. Runs where neither signal reaches the cutoff remain invalid.
This corrects the false-positive validation seen in:
Compatibility and performance
Validation
agentx-v1.0.4resolves to49634d1c6c2e6dcc18979d704a65e7c7064efc49utils/aiperf