Skip to content

[Klaud Cold] minimaxm3-fp4-b300-vllm-agentic-mtp: long-prefill-token-threshold 512 / 设置 long-prefill-token-threshold 512 #2539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xinli-sw wants to merge 2 commits into from
Closed

[Klaud Cold] minimaxm3-fp4-b300-vllm-agentic-mtp: long-prefill-token-threshold 512 / 设置 long-prefill-token-threshold 512 #2539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0101312
minimaxm3 fp4 b300 agentic mtp: set --long-prefill-token-threshold 512
xinli-sw Aug 9, 2026
e517b61
fix perf-changelog
xinli-sw Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions benchmarks/single_node/agentic/minimaxm3_fp4_b300_mtp.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ VLLM_CMD=(
--max-cudagraph-capture-size 512
--max-num-batched-tokens 16384
--stream-interval 20
--long-prefill-token-threshold 512 \

@claude claude Bot Aug 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Line 105 has a stray trailing backslash inside the VLLM_CMD array literal after --long-prefill-token-threshold 512. It's harmless since bash array elements are already newline-separated (the surviving whitespace still splits 512 and --trust-remote-code into separate words), but it's an unneeded copy-paste artifact inconsistent with the rest of the array — remove it for consistency.

Extended reasoning...

What the bug is

Line 105 of minimaxm3_fp4_b300_mtp.sh adds a new array element to VLLM_CMD:

    --long-prefill-token-threshold 512 \
    --trust-remote-code

The trailing backslash at the end of the new line is a line-continuation character. It has no functional purpose here because VLLM_CMD is a bash array literal — array elements are already delimited by newlines/whitespace, not by continuation. None of the other ~20 elements in this array (lines 89-108) use a trailing backslash.

Why it appears harmless (and the proof)

Backslash-newline in bash is spliced out, effectively joining line 105 and 106 into one logical line before word-splitting occurs. But the space before the backslash and the leading whitespace of line 106 both survive the splice, so the tokenizer still sees two distinct words:

$ arr=( a 20  b 512 \
    c )
$ declare -p arr
declare -a arr=([0]="a" [1]="20" [2]="b" [3]="512" [4]="c")

512 and --trust-remote-code/c remain separate array elements either way. So the actual vllm serve invocation (verified via the script's own printf '%q ' "${VLLM_CMD[@]}" dump) is unaffected — this is not a functional bug.

Why it looks like a mistake anyway

The file does legitimately use backslash-continuation elsewhere — e.g. the printf calls at lines 42, 62, and 66-67 span multiple lines for readability. The stray backslash on line 105 reads as if it were copy-pasted from one of those printf forms into the array context, where it serves no purpose and is simply confusing to a future reader who might assume it changes parsing behavior.

Fix

Drop the trailing backslash so line 105 reads:

    --long-prefill-token-threshold 512

matching the style of every other element in the VLLM_CMD array.

Verifier notes

All three independent verifiers reproduced the harmlessness claim with the same arr=(...) experiment and confirmed no other array element uses continuation. No refutations were raised. This is purely a cosmetic/consistency nit — it does not affect the server command, does not block merge, and should be graded nit per the [quality] classification.

--trust-remote-code
--speculative-config "$SPEC_CONFIG"
"${OFFLOAD_ARGS[@]}"
Expand Down
6 changes: 6 additions & 0 deletions perf-changelog.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5688,3 +5688,9 @@
- "Use the official lmsysorg/sglang:v0.5.16-rocm720-mi30x image, enable SGLang prompt-cache reporting, and pass the backend Prometheus metrics endpoint explicitly to AIPerf"
- "Allow up to 30 minutes for healthy AgentX responses admitted near the end of the measurement window to drain before AIPerf finalizes profile metric coverage"
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/2528

- config-keys:
- minimaxm3-fp4-b300-vllm-agentic-mtp
description:
- "Set --long-prefill-token-threshold 512 for MiniMax M3 NVFP4 b300 AgentX MTP"
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/2539
Loading