-
Notifications
You must be signed in to change notification settings - Fork 253
deprcate even more stuff, cut compute cost by 60% #2406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
26a50ce
docs: announce 2026-08-03 deprecations and spec-decode-only AgentX po…
functionstackx 7892166
docs: justify spec-decode-only policy with the golden AL curves [skip…
functionstackx d837876
docs: mark the synthetic-acceptance knob list as non-exhaustive [skip…
functionstackx 3dd9c82
docs: cut GLM-5.2 AgentX non-MTP on 2026-08-03 [skip-sweep]
functionstackx b4cac66
docs: drop the GLM-5.2 MTP-prerequisite paragraph [skip-sweep]
functionstackx 3798962
fix(docs): MiniMax-M3 uses EAGLE3, not MTP [skip-sweep]
functionstackx ca783fc
Update MODELS.md
functionstackx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 The spec-decode A/B retirement table and matrix rows claim 'published' arms (Kimi-K3 DSpark; MiniMax-M3/Qwen3.5 agentic-MTP) that don't exist in configs/nvidia-master.yaml or configs/amd-master.yaml — for kimik3 both existing recipes are non-DSpark (companion PR #2391 shipped it non-DSpark because DSpark 'doesn't work with Pipeline yet'), and for minimaxm3/qwen3.5 all agentic-coding recipes have no spec-decoding field (their only -mtp variants are under the single-turn 8k1k scenario). This is a pre-existing documentation gap made worse by this PR: after 2026-08-03 these three rows will point to scenarios with no backing config, contradicting the PR's own test-plan claim that arms were cross-checked against the master configs. Recommend either dropping these three rows from the retirement table until the DSpark/MTP-agentic configs actually land, or rewording them as forward-looking intent rather than an active 'published arm'.
Extended reasoning...
The PR adds a "Speculative-decoding A/B retirements" table (MODELS.md L21-30, mirrored in MODELS_zh.md) plus corresponding matrix rows for
kimik3(L52),minimaxm3(L54), andqwen3.5(L59) that name a "Published arm" going forward: DSpark for Kimi-K3, and "Agentic coding, MTP" for MiniMax-M3 and Qwen3.5. None of these three published arms currently exist inconfigs/nvidia-master.yamlorconfigs/amd-master.yaml.For
kimik3: the only two recipes innvidia-master.yamlarekimik3-fp4-b300-vllm-agentic(nospec-decodingfield, defaults tonone) andkimik3-fp4-b200-dynamo-vllm-agentic(explicitspec-decoding: none). There is no DSpark spec-decode config anywhere in either master file — the only "DSpark" string in the whole configs tree is an unrelated architecture comment about the vLLM plugin's MLA/KDA attention kernels. The companion PR #2391 (merged immediately before this one, commit0decc69) shipped kimik3 non-DSpark specifically because "it doesn't work with Pipeline yet," with the DSpark work explicitly deferred to a follow-up. So this PR's own docs mark the only currently-runnable kimik3 arm as "deprecated from day 0" and mark the nonexistent arm as "Active"/"Published."For
minimaxm3andqwen3.5: every agentic-coding recipe in both master configs (minimaxm3-fp8-{h100,h200}-vllm-agentic, amd -mi300x/-mi325x/-mi355x-vllm-agentic; qwen3.5-fp8-{b200,b300-hicache,h100}-sglang-agentic, amd -mi355x-sglang-agentic{,-hicache}) has nospec-decodingfield. Their only-mtprecipe variants (e.g.minimaxm3-fp8-b200-vllm-mtp,qwen3.5-fp8-b200-sglang-mtp) live under the single-turn 8k1k scenario, not agentic-coding. A grep foragentic.*mtpacross both master files returns onlydsv4andkimik2.5— confirming dsv4's claimed arm in the same table is real, but minimaxm3/qwen3.5's is not.The PR's own test plan states "All model prefixes, recipe variants, and spec-decode arms cross-checked against
configs/nvidia-master.yamlandconfigs/amd-master.yaml" — this claim doesn't hold for these three rows. Concretely: (1) grepconfigs/nvidia-master.yamlandconfigs/amd-master.yamlforkimik3→ 2 hits, bothspec-decoding: noneor field-absent-defaults-to-none; (2) grep fordspark(case-insensitive) anywhere in the configs tree → 1 hit, a comment about attention kernels, not a spec-decode value; (3) grepagentic.*mtpacross both files → onlydsv4-*andkimik2.5-*keys, neverminimaxm3-*orqwen3.5-*. Since this is a docs-only PR with[skip-sweep], nothing breaks at runtime today, but after 2026-08-03 the matrix would present an "active" scenario for three models backed by no config at all, which is exactly the kind of drift MODELS.md exists to prevent.Fix: either don't table these as "published arm" until the follow-up PRs land the actual DSpark/agentic-MTP configs (kimik3's follow-up is already flagged as pending in #2391; minimaxm3/qwen3.5 would need new agentic+spec-decode recipes added first), or reword these three rows to state the intent to only publish spec-decode arms going forward rather than asserting a currently-existing "published arm."