Skip to content

[Klaud Cold][agentic experiment][Variant I] Kimi-K3 B200 agg TP8xPP2 agentic — DSpark spec decoding @ golden AL / Kimi-K3 B200 聚合式 TP8xPP2 智能体实验——DSpark 投机解码(黄金 AL) - #2376

Closed
functionstackx wants to merge 27 commits into
mainfrom
klaud/kimik3-b200-agentic-direct-vllm-dspark
Closed

Conversation

@functionstackx

@functionstackx functionstackx commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

Agentic experiment (Variant I) — Variant D (#2359) plus DSpark speculative decoding with the committed golden AL.

Identical serving stack to the fully-green Variant D (direct vllm serve via srt-slurm PR #278 + multinode patch, GPU-resident KV, NCCL_CUMEM_ENABLE=1, no allocator changes), with:

Known risks called out up front: the draft head Inferact/Kimi-K3-DSpark resolves via the shared /hf_hub_cache mount — if it isn't cached and compute nodes lack egress, engine init will fail on the draft download.

Related experiments

中文说明

智能体实验变体 I——变体 D(#2359)加 DSpark 投机解码与黄金 AL。

服务栈与全绿的变体 D 完全一致(直接 vllm serve、GPU 常驻 KV、NCCL_CUMEM_ENABLE=1、无分配器改动),另加:DSpark 投机解码(Inferact/Kimi-K3-DSpark 草稿头、num_speculative_tokens 7、FLASHINFER_MLA 注意力后端),采用合成拒绝采样注入 synthetic_acceptance_length: 3.84——该黄金 AL 在 probabilistic 草稿 + block 拒绝采样(#2366 优化)下测得(#2368,run 30316471205),符合黄金 AL 合成接受约定;并发曲线扩展为 1/2/4/8/16/32;主配置以 spec-decoding: dspark 标注(schema 新增取值,与 mtp/draft_model 并列;下游按不透明字符串处理,结果带 spec-dspark 标注)。

已预先说明的风险:草稿头需经共享 /hf_hub_cache 挂载解析,若未缓存且计算节点无外网,引擎初始化会在下载草稿模型时失败。

🤖 Generated with Claude Code

functionstackx and others added 19 commits July 27, 2026 14:34
…ecipe

Aggregated TP8 x PP2 across 2 B200 nodes (16 GPUs), plain TP (no expert
parallelism) for the agentic-coding trace replay. Dedicated bring-up image
vllm/vllm-openai:kimi-k3 with VLLM_ENABLE_K3_LATENT_MOE_TAIL_FUSION=1,
fastsafetensors load format, kimi_k3 tool-call/reasoning parsers. Model
pre-staged at /lustre/fsw/models/Kimi-K3; launch_b200-dgxc.sh gains the
kimik3/fp4 model-path mapping, the agentic recipe overlay, and the agentic
cache default_mounts used by the GB200/GB300 agentic paths.

中文:新增 Kimi-K3 MXFP4 B200 聚合式 TP8xPP2 Dynamo-vLLM 智能体编码基准测试配方
(2 节点 / 16 GPU,纯 TP,不启用专家并行(EP))。使用专用 bring-up 镜像
vllm/vllm-openai:kimi-k3(VLLM_ENABLE_K3_LATENT_MOE_TAIL_FUSION=1、
fastsafetensors 加载格式、kimi_k3 工具调用/推理解析器)。模型已预置于
/lustre/fsw/models/Kimi-K3;启动器 launch_b200-dgxc.sh 增加 kimik3/fp4
模型路径映射、智能体配方覆盖及智能体缓存挂载。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
中文:在更新日志条目与 MODELS 表格行中补充 PR #2355 链接。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…oke test

The cquil11/srt-slurm-nv cam/sa-submission-q2-2026 fork rejected the recipe
(benchmark.aiperf_server_metrics: Unknown field). Switch the b200-dgxc
agentic clone to upstream NVIDIA/srt-slurm v1.0.36 (validated in #2302/#2341),
drop the aiperf_server_metrics field, pin dynamo wheel/router to 1.2.1 (the
combination validated with v1.0.36), and reduce the bring-up to a single
conc-8 smoke test.

中文:cquil11/srt-slurm-nv 分支的 srtctl 校验拒绝了配方字段
benchmark.aiperf_server_metrics(Unknown field)。将 b200-dgxc 智能体路径改用
上游 NVIDIA/srt-slurm v1.0.36(已在 #2302/#2341 验证),移除该字段,dynamo
wheel/router 固定为 1.2.1,并将 bring-up 缩减为单并发(conc 8)冒烟测试。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The dynamo-vllm worker entrypoint rejected --enable-auto-tool-choice
--tool-call-parser kimi_k3 (unrecognized arguments; different arg parser
than vllm serve). Chat parsing happens at the dynamo frontend — same
convention as the DSv4 GB300 agentic recipes. Keep --reasoning-parser
kimi_k3 (accepted by the worker). Also drop the explicit max-model-len and
let vLLM derive the native 1M window from the model config, mirroring the
agentic recipe convention.

中文:dynamo-vllm worker 入口不接受 --enable-auto-tool-choice 与
--tool-call-parser kimi_k3(unrecognized arguments,与 vllm serve 的参数解析器
不同),聊天解析由 dynamo 前端处理,与 DSv4 GB300 智能体配方约定一致;保留
worker 可接受的 --reasoning-parser kimi_k3。同时移除显式 max-model-len,
由 vLLM 从模型配置推导原生 1M 上下文窗口。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Third sweep attempt: the engine loaded and served (TP8xPP2 healthy in ~14
min), but dynamo 1.2.1's rust frontend tokenizer rejects Kimi-K3's tiktoken
model_type 'kimi_k3' (supported: kimi, kimi_k2, kimi_k25, deepseek_v3), so
the model never registered and all chat completions returned 404, aborting
the AgentX warmup. Switch to the 1.2.0.dev20260426 wheel used by the DSv4
GB300/B200 Dynamo-vLLM recipes. Upstream published v1.4.0-kimi-k3-dev.1
(2026-07-27) as the day-zero K3 build if this wheel also lacks support.

中文:第三次扫描中引擎已成功加载并提供服务(TP8xPP2 约 14 分钟就绪),但
dynamo 1.2.1 的 rust 前端分词器不支持 Kimi-K3 的 tiktoken model_type
'kimi_k3',模型未能注册,所有请求返回 404,AgentX 预热中止。改用 DSv4
GB300/B200 Dynamo-vLLM 配方所用的 1.2.0.dev20260426 wheel;如仍不支持,
上游已于 2026-07-27 发布 day-zero 构建 v1.4.0-kimi-k3-dev.1。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Pin dynamo to ba83080ecd31c1ce918559e576d3c5bc9e092ff1 ("feat: Added
support for Kimi-K3", tag v1.4.0-kimi-k3-dev.1) via srt-slurm's
hash-cached source install: it adds the kimi_k3 tiktoken tokenizer to the
rust frontend (dynamo <=1.2.1 404s every request because the model never
registers) and accepts the kimi_k3 tool-call/reasoning parser worker args,
so restore --enable-auto-tool-choice --tool-call-parser kimi_k3
--reasoning-parser kimi_k3.

中文:将 dynamo 固定到 day-zero Kimi-K3 提交 ba83080("feat: Added support
for Kimi-K3",标签 v1.4.0-kimi-k3-dev.1),通过 srt-slurm 的哈希缓存源码
安装:该提交为 rust 前端新增 kimi_k3 tiktoken 分词器(dynamo <=1.2.1 因模型
无法注册而全部返回 404),worker 亦支持 kimi_k3 解析器参数,故恢复
--enable-auto-tool-choice --tool-call-parser kimi_k3 --reasoning-parser kimi_k3。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Replace the vLLM OpenAI-frontend spellings (--enable-auto-tool-choice /
--tool-call-parser) with dynamo's namespaced worker args:
--dyn-tool-call-parser kimi_k3 --reasoning-parser kimi_k3
--dyn-reasoning-parser kimi_k3.

中文:将 vLLM OpenAI 前端风格参数(--enable-auto-tool-choice /
--tool-call-parser)替换为 dynamo 命名空间的 worker 参数:
--dyn-tool-call-parser kimi_k3 --reasoning-parser kimi_k3
--dyn-reasoning-parser kimi_k3。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fifth sweep attempt: the day-zero dynamo registered the kimi_k3 tiktoken
tokenizer and the engine served, but all warmup requests got 400 — aiperf's
conv-aware routing emits nvext.session_control, a removed POC field this
dynamo build rejects (schema moved to router/routing_constraints/
agent_hints). Opt out via AIPERF_USE_DYNAMO_CONV_AWARE_ROUTING=0, matching
the GB300 aggregate AgentX recipes; a single aggregate worker has no P/D
routing to bind anyway.

中文:第五次扫描中 day-zero dynamo 已成功注册 kimi_k3 tiktoken 分词器并正常
服务,但全部预热请求返回 400——aiperf 的会话感知路由会发送
nvext.session_control(已被移除的 POC 字段,schema 已迁移至
router/routing_constraints/agent_hints)。通过
AIPERF_USE_DYNAMO_CONV_AWARE_ROUTING=0 关闭,与 GB300 聚合式 AgentX 配方
一致;单聚合 worker 本无需 P/D 路由绑定。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sixth sweep attempt (both A and C variants): warmup requests 500 then the
model 503s — the image's first decode step crashes in the KDA hybrid-state
postprocess (mamba_hybrid.py postprocess_state, IndexError: index_fill_():
Expected dtype int64 for index; torch requires an int64 index but the
runner passes the int32 idx_mapping). Ship an in-container patch through
srt-slurm's setup_script hook (same pattern as configs/patches/
vllm_numa_bind_hash_fix.py): coerce the index with .long(), idempotent,
refuses to run if the image layout changed.

中文:第六次扫描(A、C 两个变体一致):预热请求先 500、随后模型 503——镜像
首个解码步在 KDA 混合状态后处理中崩溃(mamba_hybrid.py postprocess_state,
IndexError: index_fill_() 需要 int64 索引,但 runner 传入 int32 idx_mapping)。
通过 srt-slurm 的 setup_script 钩子在容器内打补丁:将索引用 .long() 转换,
幂等,且镜像布局变化时拒绝执行。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Serve Kimi-K3 directly with vllm serve (srt-slurm PR #278 frontend.type:
vllm, branch kylliang/direct-aggregate-vllm): no dynamo frontend/worker/
router, which removes the dynamo tokenizer/schema gaps entirely, and the
OpenAI-frontend flags --enable-auto-tool-choice --tool-call-parser kimi_k3
--reasoning-parser kimi_k3 become legitimate. PR #278 validates single-node
only, so ship patches/srt-slurm-pr278-direct-vllm-multinode.patch extending
it to vLLM-native multi-node serve (--master-addr/--nnodes/--node-rank,
headless non-leader ranks) for the 2-node TP8xPP2 topology. Keeps the
mamba_hybrid index-dtype container patch (engine bug is frontend-agnostic).

中文:智能体实验变体 D——通过 srt-slurm PR #278(frontend.type: vllm)直接以
vllm serve 提供服务:去除 dynamo 前端/worker/router,从根本上规避 dynamo 的
分词器与 schema 兼容问题,OpenAI 前端参数 --enable-auto-tool-choice
--tool-call-parser kimi_k3 --reasoning-parser kimi_k3 因此可用。PR #278 仅
支持单节点,故新增补丁将其扩展为 vLLM 原生多节点 serve(--master-addr/
--nnodes/--node-rank,非主节点 headless),以运行 2 节点 TP8xPP2 拓扑。保留
mamba_hybrid 索引类型容器补丁(引擎缺陷与前端无关)。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
中文:将更新日志条目与 MODELS 表格行链接指向实验 PR #2359。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Same engine-level OOM as the dynamo-frontend variants: the flashinfer
trtllm MXFP4 MoE kernel allocates a ~1.6 GiB runtime workspace outside
vLLM's memory pool on the first forward; at 0.95 a 178 GiB B200 has only
~1.35 GiB free.

中文:与 dynamo 前端变体相同的引擎级 OOM:flashinfer trtllm MXFP4 MoE 内核在
首个前向时于 vLLM 显存池外分配约 1.6 GiB 工作区,0.95 下仅剩约 1.35 GiB。
改为 0.90。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Inherited from the closed dynamo-frontend variants (#2355/#2358): at
gpu-mem-util 0.90 the first long-context MLA prefill OOM'd on a 2.92 GiB
transient while 3.39 GiB sat reserved-but-unallocated (fragmentation). Set
PYTORCH_CUDA_ALLOC_CONF=expandable_segments:True and drop
NCCL_CUMEM_ENABLE.

中文:继承自已关闭的 dynamo 前端变体(#2355/#2358):0.90 显存利用率下首个
长上下文 MLA 预填充因 2.92 GiB 瞬时分配 OOM,而 3.39 GiB 处于已保留未分配
状态(碎片化)。设置 PYTORCH_CUDA_ALLOC_CONF=expandable_segments:True 并
移除 NCCL_CUMEM_ENABLE。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…refill OOM)"

This reverts commit 4370988. The superseded direct-vllm run served the
agentic benchmark for 24 minutes on the original env (NCCL_CUMEM_ENABLE=1,
no expandable_segments) without any OOM — the allocator change was
precautionary carryover from the closed dynamo-frontend variants and was
never justified by evidence from this serving path. Restore the env that
was demonstrably running.

中文:回滚 4370988。被中断的 direct-vllm 运行在原始环境
(NCCL_CUMEM_ENABLE=1、未设 expandable_segments)下已稳定运行智能体基准测试
24 分钟且无 OOM——该分配器改动只是从已关闭的 dynamo 前端变体沿袭的预防性
措施,并无本服务路径上的证据支持。恢复已被验证可运行的环境。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Keep prefix-cache blocks alive across agentic turn gaps, matching the
GB200/GB300 AgentX recipes.

中文:新增 VLLM_PREFIX_CACHE_RETENTION_INTERVAL=32768,使前缀缓存块在智能体
回合间隔内保持留存,与 GB200/GB300 AgentX 配方一致。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
中文:将智能体并发列表从单点 8 扩展为 1/8/16/32。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Engine init hard-fails on Kimi-K3 with the GB200/GB300 AgentX value:
"VLLM_PREFIX_CACHE_RETENTION_INTERVAL (32768) must be non-negative and a
multiple of scheduler_block_size (3145728)" — the KDA hybrid architecture
gives K3 a 3.1M-token scheduler block. Default retention served fine in
the earlier runs, so drop the override.

中文:移除 VLLM_PREFIX_CACHE_RETENTION_INTERVAL——Kimi-K3 的 KDA 混合架构使
scheduler_block_size 达 3145728,GB200/GB300 AgentX 的 32768 取值导致引擎
初始化直接失败(必须为其整数倍)。此前运行证明默认留存策略可正常服务,
故不再覆盖。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Variant D (#2359) plus DSpark speculative decoding with the
Inferact/Kimi-K3-DSpark draft head: num_speculative_tokens 7,
FLASHINFER_MLA attention backend, probabilistic draft sampling + block
rejection sampling (the #2366 acceptance-rate optimization), and
synthetic_acceptance_length 3.84 — the committed golden AL for exactly
this sampling config at k=7 (#2368, measured in run 30316471205). Conc
curve widened to 1/2/4/8/16/32; spec-decoding labeled draft_model.

中文:智能体实验变体 I——变体 D(#2359)加 DSpark 投机解码
(Inferact/Kimi-K3-DSpark 草稿头):num_speculative_tokens 7、
FLASHINFER_MLA 注意力后端、probabilistic 草稿采样 + block 拒绝采样
(#2366 的接受率优化),synthetic_acceptance_length 3.84 即该采样配置在
k=7 下的黄金 AL(#2368,run 30316471205 测得)。并发曲线扩展为
1/2/4/8/16/32;spec-decoding 标注为 draft_model。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ntic-direct-vllm-dspark

# Conflicts:
#	perf-changelog.yaml
functionstackx and others added 3 commits July 28, 2026 00:25
中文:将更新日志条目与 MODELS 表格行链接指向实验 PR #2376。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Extend the spec-decoding schema Literal with "dspark" (alongside
mtp/draft_model/none) and label the variant I entry dspark instead of
draft_model. Downstream consumers (workflow env, result filenames,
process_result) treat the value as an opaque string, so results carry
spec-dspark.

中文:为 spec-decoding 的 schema Literal 新增 "dspark"(与
mtp/draft_model/none 并列),并将变体 I 的条目由 draft_model 改标为
dspark。下游(工作流环境变量、结果文件名、process_result)将该值视为
不透明字符串,结果将带有 spec-dspark 标注。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Rename agg-b200-tp8pp2-agentic.yaml to agg-b200-tp8pp2-dspark-agentic.yaml
on this branch, matching the <topology>-<spec-method>-agentic naming of the
DSv4 MTP recipes, and update the CONFIG_FILE routing and changelog. Also
add method context: DSpark is DeepSeek's confidence-scheduled
semi-autoregressive speculative decoding (arXiv 2607.05147), reported
~27-31% higher accepted length than EAGLE3 and 60-85% faster per-user
generation than MTP-1 at matched throughput.

中文:将变体 I 的配方文件更名为 agg-b200-tp8pp2-dspark-agentic.yaml,与
DSv4 MTP 配方的「拓扑-投机方法-agentic」命名一致,并同步更新 CONFIG_FILE
路由与更新日志。补充方法背景:DSpark 为 DeepSeek 的置信度调度半自回归投机
解码框架(arXiv 2607.05147),报告显示接受长度较 EAGLE3 高约 27-31%,同等
吞吐下单用户生成速度较 MTP-1 快 60-85%。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional findings (outside current diff — PR may have been updated during review):

  • 🔴 benchmarks/multi_node/srt-slurm-recipes/vllm/kimi-k3/agentic/agg-b200-tp8pp2-agentic.yaml:112 — The speculative-config on line 112 sets rejection_sample_method: block together with synthetic_acceptance_length: 3.84, but per golden_al_distribution/README.md and every other spec-decode recipe in the repo, synthetic_acceptance_length is only honored when rejection_sample_method is synthetic — with block, the run performs real (unsimulated) DSpark acceptance instead of forcing the committed golden AL, defeating the PR's stated 'DSpark spec decoding @ golden AL' purpose and violating the AgentX fairness guideline that agentic replay must simulate at the committed curve rather than measure real acceptance. The fix is a one-word change on line 112: "rejection_sample_method": "block" -> "rejection_sample_method": "synthetic".

    Extended reasoning...

    The recipe's speculative-config JSON (line 112) is:

    {"model":"Inferact/Kimi-K3-DSpark", "num_speculative_tokens":7, "method": "dspark", "attention_backend": "FLASHINFER_MLA", "draft_sample_method": "probabilistic", "rejection_sample_method": "block", "synthetic_acceptance_length": 3.84}
    

    It pairs rejection_sample_method: block with synthetic_acceptance_length: 3.84. synthetic_acceptance_length is vLLM's mechanism for forcing a committed golden acceptance length onto a speculative-decode run, but per golden_al_distribution/README.md this field is only wired up under rejection_sample_method: synthetic — the README's own worked example sets "rejection_sample_method": "synthetic" alongside synthetic_acceptance_length, and cites vllm-project/vllm#40662 as the PR that unified this field for that sampler. block selects a completely different code path (real block rejection sampling), under which the field is not consumed.

    This is corroborated by every other analogous config in the repo: all five DeepSeek-V4 GB300 MTP agentic recipes (disagg-gb300-1p1d-*-mtp-agentic.yaml, agg-gb300-tp4/tp8-mtp-agentic.yaml) and the dsv4/kimik2.5 single-node MTP/EAGLE3 bench scripts pair synthetic_acceptance_length with "rejection_sample_method":"synthetic" — there are zero precedents in the codebase pairing it with block. Even more tellingly, the collector script that measured the golden 3.84 value being injected here (benchmarks/single_node/speedbench/kimik3_fp4_b300_vllm_probabilistic_sample_method_block_rejection_sample_method.sh:380) invokes rejection_sample_method: block explicitly without synthetic_acceptance_length — because block is the real-measurement mode used to produce the golden curve, not the injection mode used to reproduce it. The golden YAML's own header (golden_al_distribution/kimik3_dspark_probabilistic_sample_method_block_rejection_sample_method.yaml) confirms this: # speculative-config: draft_sample_method=probabilistic | rejection_sample_method=block, with 3.84 at k=7 recorded as the measured AL from that real-decoding run, not a target for another real-decoding run to reproduce by chance.

    Concretely: with this config, the run performs real DSpark decoding with probabilistic draft sampling and real block rejection sampling against actual head quality on the agentic replay traffic — the exact same code path the collector used to measure the golden curve in the first place, just on different (agentic replay) traffic. Since agentic replay is not representative of the SPEED-Bench coding category used to calibrate the golden curve, the real AL produced here is not guaranteed to match 3.84, and the run silently produces non-comparable results if it happens to differ, with synthetic_acceptance_length: 3.84 sitting inert in the config doing nothing. This is exactly what Check 10 in .github/codeowner-signoff-verify-prompt.md (the repo's agentic spec-decode fairness check) is designed to catch: an agentic config enabling speculative decoding must pin rejection_sample_method: synthetic + synthetic_acceptance_length together, precisely because agentic replay traffic does not reproduce representative token-by-token acceptance behavior.

    One reviewer raised a plausible-sounding defense: that because the golden 3.84 value was itself measured under block, running block again here just repeats the same real measurement and "still yields meaningful golden-AL data." This does not hold up: the golden curve was measured against the SPEED-Bench coding category (the standardized calibration workload), not agentic-replay traffic, so there is no guarantee the same real AL reproduces under different input traffic — that non-reproducibility across workloads is exactly why the synthetic-forcing mechanism exists per the README's fairness guidelines ("a submission may choose any supported draft length, but it may not substitute a different acceptance target... vLLM supports this through synthetic rejection sampling"). Relying on block to coincidentally reproduce 3.84 on a different traffic distribution is precisely the "different acceptance target" substitution the fairness policy is written to prevent, whether or not it happens to land close to 3.84 in practice.

    The PR description itself flags this exact combination as a known, unresolved risk ("if this vLLM build only honors the synthetic AL under rejection_sample_method: synthetic, the first run's log will show it and it's a one-word change"), confirming it is unverified-as-written rather than a deliberate, validated design choice. The fix is a one-word change on line 112: "rejection_sample_method": "block" -> "rejection_sample_method": "synthetic".

Comment thread perf-changelog.yaml
- "In-container vLLM patch via setup_script kimi-k3-container-deps.sh: the kimi-k3 image's first decode step crashes in the KDA hybrid-state postprocess (vllm/v1/worker/gpu/model_states/mamba_hybrid.py postprocess_state, IndexError: index_fill_(): Expected dtype int64 for index — torch requires an int64 index but the runner passes the int32 idx_mapping; sixth sweep attempt, first warmup request 500s then the model 503s). The patch coerces the index with .long(), is idempotent, and refuses to run if the image layout changed"
- "Agentic experiment Variant I (of the #2359 direct-vllm Variant D): DSpark speculative decoding with the Inferact/Kimi-K3-DSpark draft head — num_speculative_tokens 7, FLASHINFER_MLA attention backend, probabilistic draft sampling + block rejection sampling (the #2366 acceptance-rate optimization), synthetic_acceptance_length 3.84 = the committed golden AL for this exact sampling config at k=7 (#2368's golden_al_distribution curve, measured in run 30316471205). Conc curve widened to 1/2/4/8/16/32; spec-decoding labeled draft_model"
- "Recipe: benchmarks/multi_node/srt-slurm-recipes/vllm/kimi-k3/agentic/agg-b200-tp8pp2-agentic.yaml on the cluster:b200-dgxc pool"
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/2376

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 The new perf-changelog.yaml entry's pr-link at line 5146 reads .../pull/0 instead of .../pull/2376. This isn't just a wrong link — it will fail validate_added_pr_link() in utils/validate_perf_changelog.py, which requires the link to be either the canonical .../pull/2376 or an XXX placeholder; pull/0 matches neither, so the changelog validation gate will raise ChangelogValidationError on this PR. Fix: change pull/0 to pull/2376.

Extended reasoning...

What the bug is: The changelog entry for kimik3-fp4-b200-dynamo-vllm-agentic added at the end of perf-changelog.yaml ends with:

  pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/0

instead of the correct https://github.com/SemiAnalysisAI/InferenceX/pull/2376. This was verified directly against the working tree (not just the PR diff shown in review context) — sed -n '5146p' perf-changelog.yaml confirms pull/0 is what's actually committed at HEAD.

How it happened: git blame traces this line to the merge commit ef94613 (merging origin/main into this branch), which reports a conflict in perf-changelog.yaml. The original feat commit (245e36e) had set the line to a pull/XXX placeholder (a valid, allowed value per the validator — see below), intending it to be filled in with the real PR number, 2376, before merge. The subsequent conflict resolution against main clobbered this into pull/0 instead of either keeping the XXX placeholder or filling in 2376. Notably, the PR's own diff/description show the intended value as pull/2376, and other files changed in this same PR (MODELS.md, MODELS_zh.md) correctly reference #2376 — so pull/0 is clearly an artifact of the merge, not an intentional convention. A repo-wide grep confirms pull/0 doesn't appear anywhere else in perf-changelog.yaml.

Why this breaks CI, not just metadata: utils/validate_perf_changelog.py defines validate_added_pr_link(link, pr_number) (called with pr_number=2376 during this PR's CI run) which raises ChangelogValidationError unless the link is exactly f\"https://github.com/SemiAnalysisAI/InferenceX/pull/{pr_number}\" or one of PR_LINK_PLACEHOLDERS = {'XXX', '.../pull/XXX'}. I read the function directly:

def validate_added_pr_link(link: str, pr_number: int | None) -> None:
    ...
    expected = f\"https://github.com/SemiAnalysisAI/InferenceX/pull/{pr_number}\"
    if link not in PR_LINK_PLACEHOLDERS and link != expected:
        raise ChangelogValidationError(
            f\"new PR entry must use {expected!r} or an XXX placeholder; \"
            f\"found {link!r}\"
        )

With pr_number=2376, expected is .../pull/2376. The committed value .../pull/0 is neither the expected link nor in PR_LINK_PLACEHOLDERS, so this function raises ChangelogValidationError and the changelog validation gate fails the PR run.

Step-by-step proof:

  1. git show HEAD:perf-changelog.yaml | tail -1pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/0.
  2. git blame on that line → attributed to merge commit ef94613.
  3. git show 245e36e:perf-changelog.yaml | tail -1 (the feat commit before the merge) → pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX (a valid placeholder).
  4. CI invokes validate_added_pr_link(link='https://github.com/SemiAnalysisAI/InferenceX/pull/0', pr_number=2376).
  5. expected = 'https://github.com/SemiAnalysisAI/InferenceX/pull/2376'; link is neither expected nor in {'XXX', '.../pull/XXX'}ChangelogValidationError is raised, failing the gate.

Fix: Change pull/0 to pull/2376 (or, if the PR number isn't final yet, revert to the pull/XXX placeholder, which the validator explicitly allows).

Comment thread perf-changelog.yaml
- "Add Kimi-K3 MXFP4 B200 aggregated multinode Dynamo-vLLM agentic-coding bring-up (new model on B200; first kimik3 benchmark config)"
- "Aggregated TP8 x PP2 across 2 B200 nodes (16 GPUs), plain TP (NOT TEP: ep 1, no enable-expert-parallel) — the native MXFP4 checkpoint (2.8T total params, ~1.4TB weights) does not fit one 8xB200 node, so TP8 shards attention/dense and PP2 splits the 93 layers. Aggregated mode (prefill num-worker 1 + decode num-worker 0, RECIPES.md section 5): one worker serves prefill and decode, no P/D KV transfer"
- "Dedicated bring-up image vllm/vllm-openai:kimi-k3 with VLLM_ENABLE_K3_LATENT_MOE_TAIL_FUSION=1 (fuses the K3 LatentMoE tail path), --load-format fastsafetensors, --moe-backend auto, --gpu-memory-utilization 0.90 (0.95 OOMs: the flashinfer trtllm MXFP4 MoE kernel allocates a ~1.6 GiB runtime workspace outside vLLM's pool on the first forward), --no-enable-flashinfer-autotune, --trust-remote-code, --enable-auto-tool-choice, --tool-call-parser kimi_k3, --reasoning-parser kimi_k3 (agentic experiment Variant D: the OpenAI-frontend parser flags are legitimate here because serving is DIRECT vllm serve, not the dynamo worker entrypoint that rejects them)"
- "No explicit max-model-len (vLLM derives the native 1M window from the model config; K3's KDA layers keep per-token KV small — only the 24 gated-MLA layers hold cache), prefix caching on for trajectory reuse, max-num-batched-tokens 8192 so a single long prefill cannot OOM a pipeline stage; conc 1/8/16/32"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 The bullet at perf-changelog.yaml:5139 ends with '...conc 1/8/16/32', carried over verbatim from the prior Variant D changelog entry, but the actual conc-list added in configs/nvidia-master.yaml for this config is [1, 2, 4, 8, 16, 32]. This directly contradicts the last bullet in the same changelog entry, which correctly says 'Conc curve widened to 1/2/4/8/16/32' — please update the stale bullet to match.

Extended reasoning...

The kimik3-fp4-b200-dynamo-vllm-agentic entry added in this PR to perf-changelog.yaml contains two bullets that describe the same concurrency sweep but state different values. The bullet at line 5139 reads:

"...max-num-batched-tokens 8192 so a single long prefill cannot OOM a pipeline stage; conc 1/8/16/32"

while the entry's final bullet (line ~5144) reads:

"Conc curve widened to 1/2/4/8/16/32"

The conc-list actually added to configs/nvidia-master.yaml for this config is [1, 2, 4, 8, 16, 32] — matching the second bullet, not the first. The 1/8/16/32 string in the first bullet was clearly copy-pasted verbatim from the prior Variant D changelog entry (which predates the addition of the 2 and 4 concurrency points) and simply never got updated when the conc-list was widened for this variant.

Step-by-step proof:

  1. configs/nvidia-master.yaml (this PR's diff) sets conc-list: [1, 2, 4, 8, 16, 32] for kimik3-fp4-b200-dynamo-vllm-agentic.
  2. perf-changelog.yaml line 5139 (same PR, same changelog entry) says "...conc 1/8/16/32" — missing 2 and 4.
  3. perf-changelog.yaml line ~5144 (same entry, later bullet) says "Conc curve widened to 1/2/4/8/16/32" — matches the actual conc-list.
  4. Bullets 1 and 6 of the same changelog entry now contradict each other about what concurrencies were swept.

This is confined entirely to human-readable changelog prose. utils/validate_perf_changelog.py only validates structure, ordering, and the PR link — it does not cross-check bullet text against the conc-list in the master config, so there is no CI enforcement that would have caught this, and none will break as a result of leaving it as-is. The authoritative, machine-consumed value (nvidia-master.yaml's conc-list) is correct, and a reader who reaches the entry's last bullet gets the correct information anyway.

The fix is a one-word/one-string edit: change "conc 1/8/16/32" to "conc 1/2/4/8/16/32" (or simply drop the redundant conc mention from the first bullet since the last bullet already states it correctly) so the entry is internally consistent.

…ntic-direct-vllm-dspark

# Conflicts:
#	perf-changelog.yaml
@github-actions

Copy link
Copy Markdown
Contributor

Replace draft_sample_method=probabilistic + rejection_sample_method=block
with rejection_sample_method=synthetic. The golden AL (3.84 at k=7) was
MEASURED under probabilistic+block (#2366/#2368); the benchmark injects it
via synthetic rejection sampling per the golden-AL convention
(golden_al_distribution/README.md), the same pattern as the DSv4 MTP
recipes (rejection_sample_method synthetic + synthetic_acceptance_length).

中文:将 draft_sample_method=probabilistic + rejection_sample_method=block
替换为 rejection_sample_method=synthetic。黄金 AL(k=7 时 3.84)是在
probabilistic+block 下测得(#2366/#2368);基准测试按黄金 AL 约定通过合成
拒绝采样注入该值(golden_al_distribution/README.md),与 DSv4 MTP 配方的
模式一致。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
functionstackx added a commit that referenced this pull request Jul 28, 2026
Same change as variant I (#2376): rejection_sample_method=synthetic with
synthetic_acceptance_length 3.84, replacing the probabilistic+block
serving combo the golden AL was measured under.

中文:与变体 I(#2376)相同的修改:rejection_sample_method=synthetic 并注入
synthetic_acceptance_length 3.84,替换黄金 AL 测量时所用的
probabilistic+block 服务组合。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

functionstackx and others added 2 commits July 28, 2026 02:58
Engine init died with "NotImplementedError: Pipeline parallelism is not
supported for this model" — SpeculativeConfig verifies the draft model
against a parallel config that unconditionally inherits the target's
pipeline_parallel_size (2), and the Inferact/Kimi-K3-DSpark draft head
does not implement SupportsPP. At runtime V1 drafters load ONLY on the
final pipeline stage (vllm-project/vllm#16568), effectively
draft_pipeline_parallel_size=1, and upstream has no config knob for it —
so extend the in-container patch script to verify the draft against a
pp=1 view of the parallel config. Idempotent; refuses to patch if the
call-site shape changed.

中文:引擎初始化报 "Pipeline parallelism is not supported for this model"——
SpeculativeConfig 用无条件继承目标 pipeline_parallel_size(2) 的并行配置校验
草稿模型,而 Inferact/Kimi-K3-DSpark 草稿头未实现 SupportsPP。V1 运行时草稿
模型仅加载在最后一个流水线阶段(vllm#16568),等效
draft_pipeline_parallel_size=1,且上游无相应配置项——故扩展容器内补丁脚本,
以 pp=1 视图校验草稿模型。补丁幂等,调用点形态变化时拒绝执行。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The K3 DSpark head consumes aux hidden states from five target layers
(target_layer_ids [2, 23, 47, 71, 89]); the target model captures them per
PP stage, so under TP8xPP2 the layers-2/23 captures live on stage 0 and
never reach the last-stage drafter, whose combine_hidden_states projection
expects hidden_size x 5. This build's V2 runner already broadcasts sampled
counts across PP ranks (PPHandler), so the remaining gap is the aux
transport — the same gap vllm-ascend PR #12507 closes for EAGLE3. Extend
the container patch script with three coordinated edits to
kimi_k3/nvidia/model.py: preallocate aux_hidden_<layer> receive buffers
for upstream-owned aux layers, attach/pass-through captured aux states on
non-last ranks via IntermediateTensors, and merge received + local aux in
global layer order on the last rank. Anchors verified against the public
vllm kimi-k3 branch source; idempotent; refuses to patch on layout drift.

中文:K3 DSpark 草稿头消费五个目标层(target_layer_ids [2, 23, 47, 71, 89])
的辅助隐状态;目标模型按流水线阶段各自捕获,TP8xPP2 下第 2/23 层的捕获位于
阶段 0,无法到达最后阶段的草稿模型(其 combine_hidden_states 期望
hidden_size x 5)。该镜像的 V2 runner 已通过 PPHandler 跨阶段广播采样计数,
唯一缺口即辅助隐状态传输(与 vllm-ascend PR #12507 为 EAGLE3 修复的相同)。
容器补丁脚本新增三处协同修改:接收侧预分配上游辅助层缓冲、非最后阶段经
IntermediateTensors 附带/透传捕获的辅助隐状态、最后阶段按全局层序合并。
锚点已对照公开 kimi-k3 分支源码验证;幂等;源码布局变化时拒绝执行。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

The runner hard-raises "dspark with pipeline parallel is not supported"
for aux-hidden-state spec methods — the guard exists precisely because
aux captures were stage-local, which the aux-transport patch now fixes
(and PPHandler already broadcasts sampled counts across ranks in this
build). Downgrade the ValueError to a warning via the container patch
script. Anchor verified against the public kimi-k3 branch source.

中文:V2 runner 对依赖辅助隐状态的投机方法在流水线并行下硬性报错
("dspark with pipeline parallel is not supported")——该防护正是因辅助隐
状态仅限本阶段捕获而设,前一补丁已实现跨阶段传输(且该构建的 PPHandler 已
跨阶段广播采样计数)。通过容器补丁脚本将 ValueError 降级为警告。锚点已对照
公开 kimi-k3 分支源码验证。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@functionstackx

Copy link
Copy Markdown
Collaborator Author

Closing the DSpark experiment per the author's decision. State at close: the full DSpark-under-PP2 patch stack is on this branch (mamba_hybrid dtype fix, pp=1 draft verification, cross-stage aux-hidden-state transport for target_layer_ids [2, 23, 47, 71, 89], and the runner guard lift) — reusable if the experiment is revisited, e.g. once upstream lands spec-under-PP (vllm RFC #44697) or on a single-node TP8 SKU where no PP is involved. In-flight sweep cancelled.

中文:按作者决定关闭 DSpark 实验。关闭时状态:本分支已包含完整的 DSpark 流水线并行补丁栈(mamba_hybrid 类型修复、pp=1 草稿校验、跨阶段辅助隐状态传输、runner 防护解除),若日后重启实验(如上游落地 vllm RFC #44697,或改用无流水线并行的单节点 TP8 SKU)可直接复用。进行中的扫描已取消。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

1 participant