Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new --split-timestamp-days-range option to the tool merge-mature workflow to allow (and target) mature-merge planning for splits whose timestamp ranges span multiple UTC days.
Changes:
- Added
split_timestamp_days_rangetoMatureMergeConfigwith default0(single-day behavior). - Added CLI flag
--split-timestamp-days-rangeand plumbed it intoMatureMergeConfig. - Updated merge planning logic/documentation to filter splits based on the configured day-bucket range.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
quickwit/quickwit-indexing/src/mature_merge_plan.rs |
Adjusts eligibility rules for assigning splits to day buckets based on a configurable day-range. |
quickwit/quickwit-indexing/src/mature_merge.rs |
Extends MatureMergeConfig with the new day-range parameter and default. |
quickwit/quickwit-cli/src/tool.rs |
Adds the new CLI flag and passes it into mature-merge configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rdettai-sk
force-pushed
the
remerge-multi-day-splits
branch
from
a7dd012 to
decf9d4
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Darkheir
approved these changes
Apr 22, 2026
rdettai-sk
force-pushed
the
remerge-multi-day-splits
branch
from
decf9d4 to
7adeca9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add --split-timestamp-days-range to enable merges of splits spanning multiple days. During a given run, only a specific range can be executed (typically 0, 1 or 2 days). Specifying 0 days only considers split for which the start and end is on the same day, which is the current behavior.