feat(rpc): make pause admin address configurable via CLI flag#437
Closed
Zhekinmaksim wants to merge 1 commit into
Closed
feat(rpc): make pause admin address configurable via CLI flag#437Zhekinmaksim wants to merge 1 commit into
Zhekinmaksim wants to merge 1 commit into
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #436.
This removes the hardcoded production pause-admin TODO from
rpc/src/auth.rsby making the address configurable via--pause-admin-address. The flag defaults to the current constant, so existing permissioned deployments keep the same behavior unless they opt into a different admin address.The address is now parsed once at startup and the node fails fast on misconfiguration instead of surfacing an error on the first emergency pause/unpause call. The configured admin address is threaded from
RunFlagsthrough RPC startup intoSummitRpcServer, and the permissioned auth path verifies against that explicit address.I also updated the permissioned RPC integration tests and the node bin helpers that construct
RunFlagsmanually so the workspace continues to compile under--features permissioned.Validation:
cargo fmt --checkcargo check -p summit-rpc --features permissionedcargo test -p summit-rpc --features permissionedcargo check -p summit --features permissionedcargo clippy --features permissionedOpened against
main, which is the current default branch. If you would prefer this on another active audit branch, I can retarget.