fix: enforce finalized block/certificate binding#405
Conversation
|
This looks like it fixes the main #329 path in the syncer: One small concern: the finalizer fallback check happens after the block has already been executed, forkchoice committed, finalized height notified, and the syncer acked. Since the check is meant to prevent a block/certificate mismatch, should it run before The normal syncer path should now prevent this case, so I don’t think this is the original issue still being open. But as defense-in-depth, the finalizer should probably reject the mismatched pair before applying any state changes. |
dcea243 to
5f30f5d
Compare
|
Update(5f30f5d):
|
|
This looks good to me now |
5f30f5d to
8621be5
Compare
8621be5 to
cecf9c1
Compare
Addresses #329.
Changes: