Skip to content

fix: validate fee recipient for proposed block#206

Merged
matthias-wright merged 2 commits into
audit-may-2026from
m/fee-recipient
Jun 30, 2026
Merged

fix: validate fee recipient for proposed block#206
matthias-wright merged 2 commits into
audit-may-2026from
m/fee-recipient

Conversation

@matthias-wright

Copy link
Copy Markdown
Collaborator

Builds on #191 (which builds on #190).

This addresses #200.

Changes:

  • Adds a check for the fee recipient to handle_verify. This check is only performed, if the treasury_address is non-zero. If the treasury_address is set to the zero address, then block proposers may chose any fee recipient.
  • Adds unit tests for verifying this.

@matthias-wright matthias-wright changed the title M/fee recipient fix: validate fee recipient for proposed block May 19, 2026
@evonide

evonide commented May 21, 2026

Copy link
Copy Markdown

This appears to verify the fee recipient when treasury mode is nonzero but leaves the zero-treasury/proposer-recipient case unchecked. Should verification require the payload fee recipient to match the expected proposer withdrawal address in that mode, too?

@matthias-wright

Copy link
Copy Markdown
Collaborator Author

When the treasury address is set to zero, the block proposer may use its own address for the fee recipient (or any other address), so I think this check should cover it.

@evonide

evonide commented Jun 5, 2026

Copy link
Copy Markdown

LGTM! This passes the treasury address through aux data and rejects received blocks whose payload pays a different recipient.

@matthias-wright matthias-wright merged commit 56188d6 into audit-may-2026 Jun 30, 2026
4 checks passed
@matthias-wright matthias-wright deleted the m/fee-recipient branch June 30, 2026 10:42
matthias-wright added a commit that referenced this pull request Jun 30, 2026
Builds on #206 (which builds on #191 and #190).

This addresses #209.

Changes:
-In handle_verify, checks that the prev_randao is zero.
-Adds unit tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants